Update attachInterrupt.adoc #832
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more easy to find other
|
|
per1234
requested changes
May 7, 2022
| @@ -147,5 +147,8 @@ For Uno WiFiRev.2, Due, Zero, MKR Family and 101 boards the *interrupt number = | |||
| [float] | |||
| === See also | |||
|
|
|||
| [role="language"] | |||
| * #LANGUAGE# link:../../external-interrupts/detachinterrupt[detachInterrupts()] | |||
There was a problem hiding this comment.
Suggested change
| * #LANGUAGE# link:../../external-interrupts/detachinterrupt[detachInterrupts()] | |
| * #LANGUAGE# link:../../external-interrupts/detachinterrupt[detachInterrupt()] |
Correct function name.
Comment on lines
152
to
+153
| -- | ||
|
|
There was a problem hiding this comment.
Suggested change
| -- | |
| -- |
Use formatting style established by the reference sample:
Let's leave this part as it was because it is unrelated to the proposal and this is how the reference sample is formatted:
|
Hi @krzky. I wanted to check back in with you. If you will update the pull request according to the instructions I provided above I will be happy to merge this valuable enhancement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more easy to find other