feat: Add sha512 patches #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 27, 2024
adr1anh
approved these changes
Sep 30, 2024
sha2/src/sha512/succinct.rs
Outdated
| zkvm_state[8] = 0; // set initial `i` | ||
| for _ in 0..80 { | ||
| unsafe { | ||
| syscall_sha512_compress(w.as_mut_ptr(), zkvm_state.as_mut_ptr()); |
There was a problem hiding this comment.
We can replace zkvm_state with a pointer to (i, &k[i])
There was a problem hiding this comment.
I've opted to instead use a global ZKVM_STATE array for now, which enables sharing of the K constants between all compress calls.
wwared
force-pushed
the
zkvm-next
branch
3 times, most recently
from
6c9f3b1 to
1d397ef
Compare
storojs72
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR: argumentcomputer/sphinx#179 and argumentcomputer/zk-light-clients#256
Note: The Sphinx PR should be merged before this one