feat: Add Blake2s benchmark program #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storojs72
force-pushed
the
blake2s-program
branch
from
ba9d88f to
d5a7055
Compare
wwared
reviewed
Sep 23, 2024
tchataigner
suggested changes
Sep 23, 2024
kadena/Cargo.lock
Outdated
There was a problem hiding this comment.
An update of the lock file can make sense but a deletion might be a tad too violent 😄
There was a problem hiding this comment.
Sorry, that was accidentally. Returned it back
storojs72
force-pushed
the
blake2s-program
branch
from
d5a7055 to
b8f79f9
Compare
storojs72
force-pushed
the
blake2s-program
branch
from
b8f79f9 to
a3b16f2
Compare
wwared
reviewed
Sep 26, 2024
There was a problem hiding this comment.
I think the code in this PR is good to merge, except we need to merge argumentcomputer/sphinx#176 first and point the Cargo.toml back at dev instead of artem/blake2s
storojs72
force-pushed
the
blake2s-program
branch
from
a3b16f2 to
e75152a
Compare
storojs72
force-pushed
the
blake2s-program
branch
from
e75152a to
4de9483
Compare
wwared
reviewed
Sep 27, 2024
| [patch.crates-io] | ||
| # Sphinx patch | ||
| #tiny-keccak = { git = "https://github.com/sp1-patches/tiny-keccak", branch = "patch-v2.0.2" } | ||
| sha2 = { git = "https://github.com/sp1-patches/RustCrypto-hashes", branch = "patch-v0.10.8" } |
There was a problem hiding this comment.
I think we need to keep this [patch.crates-io] section, though we can point it at our own fork (zkvm branch) instead of the sp1-patches one
| [patch.crates-io] | ||
| # Sphinx patch | ||
| #tiny-keccak = { git = "https://github.com/sp1-patches/tiny-keccak", branch = "patch-v2.0.2" } | ||
| sha2 = { git = "https://github.com/sp1-patches/RustCrypto-hashes", branch = "patch-v0.10.8" } |
|
On hold for a while as it requires new sphinx release |
|
Closing in favour of #256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds simple Sphinx program that performs single blake2s hashing, useful for testing and benchmarking the correspondent precompile (argumentcomputer/sphinx#176).
The integration code is located here.
This PR is better to merge after argumentcomputer/sphinx#176 with correspondent update to Cargo.toml.
Nit: In order to compile the programs (run
make), it is necessary to downgradehybrid-arraydependency in every program inprogramsand also in the kadena workspace (hardcoding 0.2.0-rc.9 version in Cargo.toml didn't help me to workaround this):