Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Update pre-commit versions #695

Merged
merged 32 commits into from
Jul 10, 2024
Merged

CI: Update pre-commit versions #695

merged 32 commits into from
Jul 10, 2024

Conversation

sugetha24
Copy link
Contributor

@sugetha24 sugetha24 commented Jun 3, 2024 •
edited
Loading

Change Summary

Update pre-commit versions

  • pre-commit/pre-commit-hooks rev: v2.4.0 -> rev: v4.6.0
  • Lucas-C/pre-commit-hooks -> rev: v1.5.4 -> rev: v1.5.5
  • pylint rev: "v2.16.1" -> rev: "v3.1.1"
  • yamllint rev: 'v1.23.0' -> rev: 'v1.35.1'
  • markdownlint-cli rev: v0.32.1 -> rev: v0.41.0

@sugetha24 sugetha24 requested a review from carlbuchmann June 3, 2024 17:35
@github-actions github-actions bot added the type: Code quality Issue related to code quality in repository label Jun 3, 2024
@carlbuchmann carlbuchmann changed the title CI: updating min python version to 3.11 CI: updating python version to 3.11 for pre-commit and ansible-test workflows Jun 3, 2024
@github-actions github-actions bot added data-model changes module: cv_configlet Issue related to cv_configlet module module: cv_configlet_v3 Issue related to cv_cononfiglet module in v3 module: cv_container Issue related to cv_container module module: cv_container_v3 Issue related to cv_container module in v3 module: cv_device Issue related to cv_device module module: cv_device_v3 Issue related to cv_device module in v3 module: cv_facts Issue related to cv_facts module module: cv_facts_v3 module: cv_task Issue related to cv_task module module: cv_task_v3 Issue related to cv_tasks module in v3 module_utils: cv_client cv_client implementation issue role: configlets_sync Issues related to configlets_sync role role: ztp_configuration Issue related to ztp_configuration role type: documentation Improvements or additions to documentation labels Jun 3, 2024
@carlbuchmann carlbuchmann mentioned this pull request Jun 3, 2024
Closed
@carlbuchmann carlbuchmann changed the title CI: updating python version to 3.11 for pre-commit and ansible-test workflows CI: Update pre-commit versions Jun 3, 2024
@github-actions github-actions bot added the type: dependencies Issue related to repository content label Jun 3, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sugetha24 sugetha24 force-pushed the python_version_upgrade branch from fbf28e6 to 26b58d7 Compare June 27, 2024 18:52
carlbuchmann
carlbuchmann reviewed Jul 10, 2024
View reviewed changes
tests/Makefile Outdated Show resolved Hide resolved
carlbuchmann
carlbuchmann approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Collection code testing / Validate code V3 with Pytest CI tests are expected to fail, and will be fixed with #694

@sugetha24 sugetha24 merged commit 4dd13d5 into aristanetworks:devel Jul 10, 2024
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@sugetha24 sugetha24

Labels
data-model changes module: cv_configlet_v3 Issue related to cv_cononfiglet module in v3 module: cv_configlet Issue related to cv_configlet module module: cv_container_v3 Issue related to cv_container module in v3 module: cv_container Issue related to cv_container module module: cv_device_v3 Issue related to cv_device module in v3 module: cv_device Issue related to cv_device module module: cv_facts_v3 module: cv_facts Issue related to cv_facts module module: cv_task_v3 Issue related to cv_tasks module in v3 module: cv_task Issue related to cv_task module module_utils: cv_client cv_client implementation issue role: configlets_sync Issues related to configlets_sync role role: ztp_configuration Issue related to ztp_configuration role type: Code quality Issue related to code quality in repository type: dependencies Issue related to repository content type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sugetha24 @carlbuchmann