Apply suggestions from code review

aristanetworks · Aug 21, 2024 · dd6f6d1 · dd6f6d1
1 parent 135c47c
commit dd6f6d1
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 16 deletions.
diff --git a/...lections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md b/...lections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
diff --git a/...ions/arista/avd/roles/eos_cli_config_gen/docs/tables/port-channel-interfaces.md b/...ions/arista/avd/roles/eos_cli_config_gen/docs/tables/port-channel-interfaces.md
diff --git a/python-avd/pyavd/_eos_cli_config_gen/schema/eos_cli_config_gen.schema.yml b/python-avd/pyavd/_eos_cli_config_gen/schema/eos_cli_config_gen.schema.yml
diff --git a/python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml b/python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
@@ -817,7 +817,7 @@ keys:
             warning: true
             removed: false
             remove_in_version: 6.0.0
-            new_key: ethernet_interfaces[].switchport.vlan_tanslations
+            new_key: ethernet_interfaces[].switchport.vlan_translations
           type: list
           items:
             type: dict
@@ -1445,7 +1445,7 @@ keys:
             access_vlan:
               type: int
               convert_types:
-                - "str"
+                - str
               min: 1
               max: 4094
               # TODO: AVD6.0 the warning below should be removed when the `ethernet_interfaces[].mode` and `ethernet_interface[].vlans` are removed in AVD6.0

diff --git a/...-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml b/...-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
@@ -357,7 +357,7 @@ keys:
             warning: true
             removed: false
             remove_in_version: 6.0.0
-            new_key: port_channel_interfaces[].switchport.vlan_tanslations
+            new_key: port_channel_interfaces[].switchport.vlan_translations
           type: list
           items:
             type: dict
@@ -890,7 +890,7 @@ keys:
             mode:
               type: str
               valid_values: ["access", "dot1q-tunnel", "trunk", "trunk phone"]
-              # TODO: AVD6.0 the warning below should be removed when the `port_channel_interfaces.mode` is removed in AVD6.0
+              # TODO: AVD6.0 the warning below should be removed when the `port_channel_interfaces[].mode` is removed in AVD6.0
               description: |-
                 Warning: This should not be combined with `port_channel_interfaces[].mode`
             access_vlan:
@@ -899,7 +899,7 @@ keys:
                 - "str"
               min: 1
               max: 4094
-              # TODO: AVD6.0 the warning below should be removed when the `port_channel_interfaces.mode` and `port_channel_interfaces[].vlans` are removed in AVD6.0
+              # TODO: AVD6.0 the warning below should be removed when the `port_channel_interfaces[].mode` and `port_channel_interfaces[].vlans` are removed in AVD6.0
               description: |-
                 Set VLAN when interface is in access mode.
                 Warning: This should not be combined with `port_channel_interfaces[].mode = access/dot1q-tunnel` and `port_channel_interface.vlans`.
@@ -910,10 +910,10 @@ keys:
                   type: str
                   convert_types:
                     - int
-                  # TODO: AVD6.0 the warning below should be removed when the `port_channel_interfaces.mode` and `port_channel_interfaces[].vlans` are removed in AVD6.0
+                  # TODO: AVD6.0 the warning below should be removed when the `port_channel_interfaces[].mode` and `port_channel_interfaces[].vlans` are removed in AVD6.0
                   description: |-
                     VLAN ID or range(s) of VLAN IDs (1-4094).
-                    Warning: This should not be combined with `port_channel_interfaces.mode = trunk` and `port_channel_interfaces[].vlans`.
+                    Warning: This should not be combined with `port_channel_interfaces[].mode = trunk` and `port_channel_interfaces[].vlans`.
                 native_vlan:
                   type: int
                   convert_types: