-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add switchport data model #4158
Merged
ClausHolbechArista
merged 54 commits into
aristanetworks:devel
from
Shivani-gslab:switchport_trunk
Aug 23, 2024
Merged
Feat(eos_cli_config_gen): Add switchport data model #4158
ClausHolbechArista
merged 54 commits into
aristanetworks:devel
from
Shivani-gslab:switchport_trunk
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4158
# Activate the virtual environment
source test-avd-pr-4158/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@switchport_trunk#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,switchport_trunk --force
# Optional: Install AVD examples
cd test-avd-pr-4158
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
labels
Jun 26, 2024
MaheshGSLAB
reviewed
Jun 27, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
switchport_trunk
branch
from
June 27, 2024 10:12
64fff38
to
f7fbc8f
Compare
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
switchport_trunk
branch
2 times, most recently
from
July 2, 2024 10:47
5cb63a1
to
7823203
Compare
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
switchport_trunk
branch
2 times, most recently
from
July 9, 2024 05:18
f34955b
to
f9b9286
Compare
MaheshGSLAB
reviewed
Jul 12, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
...llections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/ethernet-interfaces.yml
Outdated
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
switchport_trunk
branch
2 times, most recently
from
July 15, 2024 10:25
3c71198
to
023fe1b
Compare
Shivani-gslab
force-pushed
the
switchport_trunk
branch
from
August 21, 2024 14:30
59ce9cd
to
69ab601
Compare
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/port-channel-interfaces.j2
Outdated
Show resolved
Hide resolved
Co-authored-by: laxmikantchintakindi <[email protected]>
MaheshGSLAB
reviewed
Aug 22, 2024
...lections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
...ctions/arista/avd/molecule/eos_cli_config_gen_deprecated_vars/documentation/devices/host1.md
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
switchport_trunk
branch
from
August 22, 2024 07:54
1c4acde
to
6e4b393
Compare
Shivani-gslab
requested review from
ClausHolbechArista,
laxmikantchintakindi and
MaheshGSLAB
August 22, 2024 08:14
MaheshGSLAB
approved these changes
Aug 22, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/port-channel-interfaces.j2
Outdated
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
switchport_trunk
branch
from
August 22, 2024 10:49
a0cec5d
to
af33193
Compare
laxmikantchintakindi
approved these changes
Aug 22, 2024
...s/arista/avd/molecule/evpn_underlay_rfc5549_overlay_ebgp/documentation/devices/DC1-LEAF2B.md
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/port-channel-interfaces.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/port-channel-interfaces.j2
Outdated
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
switchport_trunk
branch
from
August 22, 2024 13:11
cc973f9
to
e093b6b
Compare
ClausHolbechArista
approved these changes
Aug 23, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Refactor eos_cli_config_gen switchport data models
Related Issue(s)
Fixes #2288
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Adding
switchport
toethernet-interfaces
andport-channel interfaces
schema and template.Config for switchport.tap and switchport.tool is implemented in PR #4174
switchport
keys.type
key.How to test
Molecule tests are added. Test in EOS CLI.
Checklist
Repository Checklist