Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for global MPLS RSVP #4634

Merged
merged 55 commits into from
Dec 16, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab commented Oct 23, 2024

Change Summary

Add support for MPLS RSVP

Related Issue(s)

Fixes part of #https://github.com/aristanetworks/avd-internal/issues/149

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Adding global MPLS RSVP support in eos_cli_config_gen

Covering below CLI config:

mpls rsvp
   refresh interval 3
   refresh method explicit
   hello interval 30 multiplier 254
   authentication type md5
   authentication sequence-number window 234
   authentication index 55 password 7 14241B062114062E142900260B1D23133B
   authentication index 766 password 7 13361E3F1B20011A2A173B
   authentication index 999 password simplePassword
   authentication index 766 active
   neighbor 1.1.1.1 authentication type md5
   neighbor 1.1.1.1 authentication index 3 active
   neighbor 1.1.12.2 authentication type none
   neighbor 1.1.12.2 authentication index 30 active
   neighbor 1.10.1.2 authentication type none
   neighbor 1.21.1.20 authentication type md5
   neighbor 10.1.1.2 authentication index 303 active
   neighbor 2::11.22.33.44 authentication type none
   neighbor 2::11.22.33.44 authentication index 3133 active
   neighbor 2001::db8 authentication type none
   neighbor 2001::db8 authentication index 31 active
   ip access-group RSVP_access_group_ipv4
   ipv6 access-group RSVP_access_group_ipv6
   fast-reroute mode link-protection
   fast-reroute reversion local
   fast-reroute bypass tunnel optimization interval 65535 seconds
   srlg strict
   label local-termination explicit-null
   preemption method soft timer 444
   mtu signaling
   !
   hitless-restart
      timer recovery 222 seconds
   !
   graceful-restart role helper
      timer restart maximum 32 seconds
      timer recovery maximum 33 seconds
   !
   graceful-restart role speaker
      timer restart 35 seconds
      timer recovery 36 seconds
   !
   p2mp
      disabled
   shutdown

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab self-assigned this Oct 23, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4634
# Activate the virtual environment
source test-avd-pr-4634/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@rsvp#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,rsvp --force
# Optional: Install AVD examples
cd test-avd-pr-4634
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 23, 2024
@Vibhu-gslab Vibhu-gslab force-pushed the rsvp branch 2 times, most recently from f2f78ad to 30f3528 Compare October 24, 2024 12:16
@Vibhu-gslab Vibhu-gslab force-pushed the rsvp branch 6 times, most recently from 6964549 to eb9f8df Compare November 7, 2024 11:19
@github-actions github-actions bot added the state: conflict PR with conflict label Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM!

@ClausHolbechArista ClausHolbechArista merged commit 777ce0c into aristanetworks:devel Dec 16, 2024
46 checks passed
emilarista pushed a commit to emilarista/ansible-avd that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants