-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI(eos_cli_config_gen): Restructured the eos_cli_config_gen router_bgp
host_vars
#4708
CI(eos_cli_config_gen): Restructured the eos_cli_config_gen router_bgp
host_vars
#4708
Conversation
router_bgp
host_varsrouter_bgp
host_vars(WIP)
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4708
# Activate the virtual environment
source test-avd-pr-4708/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@cli-restructure-part6#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,cli-restructure-part6 --force
# Optional: Install AVD examples
cd test-avd-pr-4708
ansible-playbook arista.avd.install_examples |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
router_bgp
host_vars(WIP)router_bgp
host_vars
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
Outdated
Show resolved
Hide resolved
...ista/avd/molecule/eos_cli_config_gen/intended/configs/router-bgp-evpn-vpn-import-pruning.cfg
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host2.cfg
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host2.cfg
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
Outdated
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bgp additional-paths send ecmp limit 42 | ||
neighbor PATH-SELECTION-PG-1 activate | ||
neighbor PATH-SELECTION-PG-1 additional-paths receive | ||
no neighbor PATH-SELECTION-PG-1 send |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Command is incorrect. It should be no neighbor PATH-SELECTION-PG-1 additional-paths send
Change Summary
Restructured the eos_cli_config_gen
router_bgp
host_vars.Related Issue(s)
Fixes #https://github.com/aristanetworks/avd-internal/issues/171
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Restructured the eos_cli_config_gen
router_bgp
host_vars.How to test
Run eos_cli_config_gen molecule then run tox command to generate the coverage report.
molecule converge -s eos_cli_config_gen
tox -e coverage,report
Checklist
User Checklist
Repository Checklist