Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(eos_cli_config_gen): Restructured the eos_cli_config_gen router_bgp host_vars #4708

Merged

Conversation

MaheshGSLAB
Copy link
Contributor

Change Summary

Restructured the eos_cli_config_gen router_bgp host_vars.

Related Issue(s)

Fixes #https://github.com/aristanetworks/avd-internal/issues/171

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Restructured the eos_cli_config_gen router_bgp host_vars.

How to test

Run eos_cli_config_gen molecule then run tox command to generate the coverage report.

molecule converge -s eos_cli_config_gen
tox -e coverage,report

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB self-assigned this Nov 11, 2024
@MaheshGSLAB MaheshGSLAB changed the title CI(eos_cli_config_gen): Restructured the eos_cli_config_gen router_bgp host_vars CI(eos_cli_config_gen): Restructured the eos_cli_config_gen router_bgp host_vars(WIP) Nov 11, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4708
# Activate the virtual environment
source test-avd-pr-4708/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@cli-restructure-part6#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,cli-restructure-part6 --force
# Optional: Install AVD examples
cd test-avd-pr-4708
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Nov 11, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Nov 11, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@MaheshGSLAB MaheshGSLAB changed the title CI(eos_cli_config_gen): Restructured the eos_cli_config_gen router_bgp host_vars(WIP) CI(eos_cli_config_gen): Restructured the eos_cli_config_gen router_bgp host_vars Nov 13, 2024
@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 13, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review November 14, 2024 11:38
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners November 14, 2024 11:38
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Nov 15, 2024
@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 15, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

@alexeygorbunov alexeygorbunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexeygorbunov alexeygorbunov added the one approval This PR has one approval and is only missing one more. label Nov 20, 2024
@ClausHolbechArista ClausHolbechArista merged commit 8f95f4e into aristanetworks:devel Nov 21, 2024
46 checks passed
ashenoy-arista pushed a commit to ashenoy-arista/avd that referenced this pull request Nov 21, 2024
bgp additional-paths send ecmp limit 42
neighbor PATH-SELECTION-PG-1 activate
neighbor PATH-SELECTION-PG-1 additional-paths receive
no neighbor PATH-SELECTION-PG-1 send
Copy link
Contributor Author

@MaheshGSLAB MaheshGSLAB Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command is incorrect. It should be no neighbor PATH-SELECTION-PG-1 additional-paths send

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: CI(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants