Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add interface traffic engineering and TE admin group for ethernet/port-channel #4754

Merged
merged 11 commits into from
Dec 17, 2024
Merged

Feat(eos_cli_config_gen): Add interface traffic engineering and TE admin group for ethernet/port-channel #4754

merged 11 commits into from
Dec 17, 2024

Conversation

emilarista
Copy link
Contributor

@emilarista emilarista commented Nov 22, 2024 •
edited
Loading

Change Summary

Adds data model for interface traffic engineering and te admin groups for ethernet and port-channel interfaces.

Component(s) name

arista.avd.eos_cli_config_gen

Issues

Fixes part of #https://github.com/aristanetworks/avd-internal/issues/149

Proposed changes

Adds the following data model to ethernet and port-channel interfaces:

    traffic_engineering:
      enabled: <bool>
      administrative_groups: <list>

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions GitHub Actions
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4754
# Activate the virtual environment
source test-avd-pr-4754/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/emilarista/ansible-avd.git@feat/eos_cli_config_gen/interface-te-admingrp#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/emilarista/ansible-avd.git#/ansible_collections/arista/avd/,feat/eos_cli_config_gen/interface-te-admingrp --force
# Optional: Install AVD examples
cd test-avd-pr-4754
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Nov 22, 2024
@emilarista emilarista marked this pull request as ready for review November 27, 2024 07:11
@emilarista emilarista requested review from a team as code owners November 27, 2024 07:11
MaheshGSLAB
MaheshGSLAB reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firs round of review and same comments applicable for Port-Channel interfaces.

python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2 Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/ethernet-interfaces.j2 Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2 Outdated Show resolved Hide resolved
@MaheshGSLAB MaheshGSLAB requested a review from a team November 28, 2024 13:25
@github-actions github-actions bot added the state: conflict PR with conflict label Dec 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@emilarista emilarista force-pushed the feat/eos_cli_config_gen/interface-te-admingrp branch from 279768f to f7b7657 Compare December 2, 2024 13:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added state: conflict PR with conflict and removed state: conflict PR with conflict labels Dec 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@emilarista emilarista force-pushed the feat/eos_cli_config_gen/interface-te-admingrp branch from 0b93256 to 54eba7b Compare December 3, 2024 06:59
@github-actions github-actions bot removed the state: conflict PR with conflict label Dec 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@gmuloc gmuloc changed the title Feat(eos_cli_config_gen): Add interface traffic engineering and te admin group for ethernet/port-channel Feat(eos_cli_config_gen): Add interface traffic engineering and TE admin group for ethernet/port-channel Dec 3, 2024
Shivani-gslab
Shivani-gslab approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Dec 12, 2024
gmuloc
gmuloc reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two little comments on tests

ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg Outdated Show resolved Hide resolved
...arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/port-channel-interfaces.yml Outdated Show resolved Hide resolved
@emilarista emilarista mentioned this pull request Dec 17, 2024
Closed
4 tasks
@github-actions github-actions bot added the state: conflict PR with conflict label Dec 17, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@emilarista emilarista force-pushed the feat/eos_cli_config_gen/interface-te-admingrp branch from 0eb5cf1 to ded5dcb Compare December 17, 2024 12:22
@github-actions github-actions bot added type: code quality CI and development toolset role: eos_designs issue related to eos_designs role labels Dec 17, 2024
@emilarista emilarista force-pushed the feat/eos_cli_config_gen/interface-te-admingrp branch from ded5dcb to c30ecff Compare December 17, 2024 12:37
@github-actions github-actions bot removed type: code quality CI and development toolset role: eos_designs issue related to eos_designs role labels Dec 17, 2024
@ClausHolbechArista ClausHolbechArista force-pushed the feat/eos_cli_config_gen/interface-te-admingrp branch from c30ecff to b221a3c Compare December 17, 2024 13:37
@github-actions github-actions bot removed the state: conflict PR with conflict label Dec 17, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista merged commit 4fb884c into aristanetworks:devel Dec 17, 2024
46 checks passed
@emilarista emilarista mentioned this pull request Dec 17, 2024
Open
4 tasks
@emilarista emilarista deleted the feat/eos_cli_config_gen/interface-te-admingrp branch December 17, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista left review comments

@Shivani-gslab Shivani-gslab Shivani-gslab approved these changes

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@gmuloc gmuloc gmuloc approved these changes

Assignees

@emilarista emilarista

Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emilarista @gmuloc @ClausHolbechArista @MaheshGSLAB @Shivani-gslab