Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add is_hostname knob to router_isis #4755

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Feat(eos_cli_config_gen): Add is_hostname knob to router_isis #4755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33ec075
Feat(eos_cli_config_gen)-add_is_hostname_knob_to_router_isis
ccsnw Nov 22, 2024
ff7ae7b
Merge branch 'devel' into Feat(eos_cli_config_gen)-add_is_hostname_kn…
gmuloc Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...arista/avd/molecule/eos_cli_config_gen/documentation/devices/router-isis-new.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ interface Vlan4094
| Settings | Value |
| -------- | ----- |
| Instance | EVPN_UNDERLAY |
| Hostname | MYROUTER |
| Log Adjacency Changes | False |
| MPLS LDP Sync Default | True |
| Advertise Passive-only | True |
Expand Down Expand Up @@ -276,6 +277,7 @@ interface Vlan4094
```eos
!
router isis EVPN_UNDERLAY
is-hostname MYROUTER
no log-adjacency-changes
mpls ldp sync default
redistribute connected
Expand Down
1 change: 1 addition & 0 deletions ...e_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/router-isis-new.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ interface Vlan4094
ip address 10.255.252.0/31
!
router isis EVPN_UNDERLAY
is-hostname MYROUTER
no log-adjacency-changes
mpls ldp sync default
redistribute connected
Expand Down
1 change: 1 addition & 0 deletions ...ollections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/router-isis-new.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
### Routing - ISIS ###
router_isis:
instance: EVPN_UNDERLAY
is_hostname: MYROUTER
log_adjacency_changes: false
mpls_ldp_sync_default: true
spf_interval:
Expand Down
4 changes: 4 additions & 0 deletions ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/router-isis.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/router-isis.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
{% if router_isis.net is arista.avd.defined %}
| Net-ID | {{ router_isis.net }} |
{% endif %}
{% if router_isis.is_hostname is arista.avd.defined %}
| Hostname | {{ router_isis.is_hostname }} |
{% endif %}
{% if router_isis.is_type is arista.avd.defined %}
| Type | {{ router_isis.is_type }} |
{% endif %}
Expand Down
3 changes: 3 additions & 0 deletions python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-isis.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ router isis {{ router_isis.instance }}
{% if router_isis.net is arista.avd.defined %}
net {{ router_isis.net }}
{% endif %}
{% if router_isis.is_hostname is arista.avd.defined %}
is-hostname {{ router_isis.is_hostname }}
{% endif %}
{% if router_isis.router_id is arista.avd.defined %}
router-id ipv4 {{ router_isis.router_id }}
{% endif %}
Expand Down
3 changes: 3 additions & 0 deletions python-avd/pyavd/_eos_cli_config_gen/schema/eos_cli_config_gen.schema.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_isis.schema.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ keys:
router_id:
type: str
description: IPv4 Address.
is_hostname:
type: str
description: Hostname of Intermediate System.
is_type:
display_name: "IS Type"
type: str
Expand Down
Loading