Bump: New minimum requirement for ansible-core 2.16 #4871
+20
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: documentation
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4871
# Activate the virtual environment
source test-avd-pr-4871/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/carlbuchmann/[email protected]#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/carlbuchmann/avd.git#/ansible_collections/arista/avd/,bump-ansible-core-2.16-2.18 --force
# Optional: Install AVD examples
cd test-avd-pr-4871
ansible-playbook arista.avd.install_examples |
|
This file is not exposed as a part of the documentation but probably needs a bump as well? |
| pip_requirements: 'tmp-requirements-minimum.txt' | ||
| - avd_scenario: 'eos_designs_unit_tests' | ||
| ansible_version: 'ansible-core>=2.15.0,<2.16.0 --upgrade' | ||
| ansible_version: 'ansible-core>=2.16.0,<2.17.0 --upgrade' |
There was a problem hiding this comment.
We don't need this one, since it would just test 2.16.. We can remove this variant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
New minimum requirement for ansible-core 2.16
Component(s) name
Python requirements
Proposed changes
How to test
CI Should pass!