Added functionality to work with enum casting #43
+204
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: added functionality to work with enum casting
MarcosBarbalho
force-pushed
the
master
branch
from
5b834bf to
04f485f
Compare
Garanaw
reviewed
Dec 9, 2023
Garanaw
reviewed
Dec 9, 2023
|
Would be nice if this could get merged! Why the delay? |
|
@asantibanez any news regarding this PR? |
Garanaw
approved these changes
Aug 21, 2024
|
There was a version conflict because I used arrow functions in the implementation of this feature, and this functionality was added in later versions of PHP. The most recent commit fixes this. |
Garanaw
approved these changes
Aug 26, 2024
|
@asantibanez Please merge it 🙏 |
maksym-odanets
pushed a commit
to maksym-odanets/laravel-eloquent-state-machines
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Firstly, I would like to thank all the work done on this package and everyone who contributed to its development so far.
This PR enables the use of Enums and Enum Casting in the construction of State Machines.
The problem was identified by us when we tried to work with our Casting pattern and received errors reporting the incorrect type of data.
This update does not have any breaking changes, and I tried to cover as many cases as possible in the test cases.
If you see any possible improvements in how the code was written, feel free to contact me through this PR.
Thank everyone who contributed to issue #33 that reported this possible improvement.
I am available to contact via email at any time.
Thank you and LET'S GO!
Issue
#33
Type of Change
Screenshot/Video