Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: avoid use of depset.to_list #441

Merged
merged 1 commit into from
Dec 3, 2024
Merged

perf: avoid use of depset.to_list #441

merged 1 commit into from
Dec 3, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Dec 2, 2024


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@jbedard jbedard force-pushed the no-to_list branch 3 times, most recently from e22b7a0 to e729f35 Compare December 2, 2024 22:30
@alexeagle
Copy link
Member

Awesome, thanks - is this related to our customer pointing out the slowness?

Failure:

#   	File "/home/runner/.cache/bazel/_bazel_runner/89e91fd6b6dccc7b506d63833e3c5c70/external/aspect_rules_lint~/lint/stylelint.bzl", line 147, column 44, in stylelint_fix
#   		inputs = _gather_inputs(ctx, srcs) + [patch_cfg],
#   Error: unsupported binary operation: depset + list

LMK if you'd like any help greening up

@jbedard
Copy link
Member Author

jbedard commented Dec 3, 2024

is this related to our customer pointing out the slowness?

Yeah, someone mentioned the to_list call so I thought I'd test try this out. I haven't actually profiled anything and fully depending on CI for testing it, but if we can drop the to_list call and things are green then sgtm.

Can you tag a release once this is merged?

@jbedard jbedard marked this pull request as ready for review December 3, 2024 19:18
@jbedard jbedard requested a review from alexeagle December 3, 2024 19:18
@alexeagle
Copy link
Member

I just cut a release this morning, but you can make another one if it's important to roll this fix to a user.
Note that the release instructions in this repo now have our New Shiny Automation: https://github.com/aspect-build/rules_lint/blob/main/CONTRIBUTING.md#releasing

@jbedard
Copy link
Member Author

jbedard commented Dec 3, 2024

It's not urgent so I won't do a release atm. If we're pinged about releasing we can do it then.

@jbedard jbedard merged commit 6ade9f8 into main Dec 3, 2024
7 checks passed
@jbedard jbedard deleted the no-to_list branch December 3, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants