Flake8 #5
Merged
Flake8 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
flake8
branch
2 times, most recently
from
c3bf01a to
2d371e7
Compare
point to adding linter instructions
alexeagle
force-pushed
the
flake8
branch
2 times, most recently
from
949c47e to
a0517d0
Compare
First commit in "how to add a new linter".
Second commit in "how to add a new linter".
Third commit in "how to add a new linter".
kormide
approved these changes
Oct 12, 2023
| implementation = _flake8_aspect_impl, | ||
| # Edges we need to walk up the graph from the selected targets. | ||
| # Needed for linters that need semantic information like transitive type declarations. | ||
| # attr_aspects = ["deps"], |
There was a problem hiding this comment.
It's intentionally commented, this commit is also an example, so someone studying it may need this (if they wanted to add mypy, say ... @dzbarsky ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These three commits should not be squashed: they represent the three steps I'll document for adding your own linter.