Skip to content

Incoming media uploaded to S3 with public-read ACL by default #315

Description

@ThiagoBauken

Summary

All media uploaded to S3 is set ACL: public-read, making every received WhatsApp file world-readable to anyone who knows (or guesses) the URL.

Details

// s3manager.go:279
input := &s3.PutObjectInput{
    ...
    ACL: types.ObjectCannedACLPublicRead,
}

Object keys follow a predictable pattern (users/{userID}/inbox/{contactJID}/.../{messageID}.ext). On S3-compatible backends without a bucket-level public-access block (common with MinIO / self-hosted), end-user media (images, documents, audio) is publicly accessible.

Proposed fix

Make access control configurable instead of always public:

  • default to private objects and serve media via presigned GET URLs with a configurable TTL (GetPublicURL would call PresignGetObject); or
  • keep an explicit opt-in s3_public_read flag for users who want public objects + a CDN.

This is a behavior change (some users rely on the static public URL), so it likely needs a flag + migration note — filing first to agree on the default. Happy to PR.

Location

  • s3manager.go:279 (and GetPublicURL)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions