mt, chunk: always return text/plain when html == false.

astroidmail · Aug 30, 2018 · 9adbb0d · 9adbb0d
1 parent 5fc72aa
commit 9adbb0d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/src/chunk.cc b/src/chunk.cc
@@ -238,6 +238,10 @@ namespace Astroid {
 
   }
 
+  bool Chunk::is_content_type (const char * major, const char * minor) {
+    return (mime_object != NULL) && g_mime_content_type_is_type (content_type, major, minor);
+  }
+
   ustring Chunk::viewable_text (bool html = true, bool verbose) {
     if (isencrypted && !crypt->decrypted) {
       if (verbose) {
@@ -258,7 +262,7 @@ namespace Astroid {
       LOG (debug) << "chunk: body: part";
 
 
-      if (g_mime_content_type_is_type (content_type, "text", "plain")) {
+      if (is_content_type ("text", "plain")) {
         LOG (debug) << "chunk: plain text (out html: " << html << ")";
 
         GMimeDataWrapper * content = g_mime_part_get_content (
@@ -328,7 +332,7 @@ namespace Astroid {
 
         content_stream = filter_stream;
 
-      } else if (g_mime_content_type_is_type (content_type, "text", "html")) {
+      } else if (is_content_type ("text", "html")) {
         LOG (debug) << "chunk: html text";
 
         GMimeDataWrapper * content = g_mime_part_get_content (

diff --git a/src/chunk.hh b/src/chunk.hh
@@ -30,6 +30,7 @@ namespace Astroid {
       ustring content_id;
 
       ustring get_content_type ();
+      bool    is_content_type (const char* major, const char* minor);
 
       ustring viewable_text (bool, bool verbose = false);
 

diff --git a/src/message_thread.cc b/src/message_thread.cc
@@ -316,13 +316,13 @@ namespace Astroid {
       bool use = false;
 
       if (c->siblings.size() >= 1) {
-        if (c->preferred) {
+        if (c->is_content_type ("text", html ? "html" : "plain")) {
           use = true;
         } else {
           /* check if there are any other preferred */
           if (all_of (c->siblings.begin (),
                       c->siblings.end (),
-                      [](refptr<Chunk> c) { return (!c->preferred); })) {
+                      [html](refptr<Chunk> c) { return !c->is_content_type ("text", html ? "html" : "plain"); })) {
             use = true;
           } else {
             use = false;
@@ -333,7 +333,7 @@ namespace Astroid {
       }
 
       if (use) {
-        if (c->viewable && (c->preferred || html || fallback_html)) {
+        if (c->viewable && (c->is_content_type ("text", html ? "html" : "plain") ||  fallback_html)) {
           body += c->viewable_text (html);
         }