Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added the CFP form #348

Merged
merged 75 commits into from
Aug 30, 2024

Conversation

ashmit-coder
Copy link
Collaborator

Description

  • Adds the CFP form to the conference site

Related issue(s)

#323

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 18dc455
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/66d1c995af3c750008279fb4
😎 Deploy Preview https://deploy-preview-348--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashmit-coder ashmit-coder changed the title feat: Added the CFP form feat: added the CFP form Jul 22, 2024
@thulieblack
Copy link
Member

yo @ashmit-coder where is the page of the cfp form?

@ashmit-coder
Copy link
Collaborator Author

yo @ashmit-coder where is the page of the cfp form?

It's in the route /speakers/registration .
And the cfp page is in /speakers.

They are not yet accessible by any buttons, which is one of my questions.

@thulieblack
Copy link
Member

I can't see it could you share how?

Otherwise add a page from Venue/Online the also add the form there

@ashmit-coder
Copy link
Collaborator Author

I can't see it could you share how?

Otherwise add a page from Venue/Online the also add the form there

https://deploy-preview-348--peaceful-ramanujan-288045.netlify.app/speakers

@ashmit-coder
Copy link
Collaborator Author

I can't see it could you share how?

Otherwise add a page from Venue/Online the also add the form there

I didn't quite understand the second point you made

@thulieblack
Copy link
Member

thulieblack commented Jul 24, 2024

But if you put it under Speaker, then this won't be there

image

What I'm saying is create a new page under the Venue dedicated for Online Conference then move the CFP form to that page

@ashmit-coder
Copy link
Collaborator Author

But if you put it under Speaker, then this won't be there

image

What I'm saying is create a new page under the Venue dedicated for Online Conference then move the CFP form to that page

okay understood, I will do that

@ashmit-coder
Copy link
Collaborator Author

https://deploy-preview-348--peaceful-ramanujan-288045.netlify.app/venue/online

hey @thulieblack is this how you wanted it to be changed?

@ashmit-coder
Copy link
Collaborator Author

Hey @ashmit-coder I'll do a long review for you.

1. fix this and make it Online, Edition

image

2. For consistency across the website, please return it to white

image

3. Rename to AsyncAPI Youtube Channel

image

4. Remove the following

image

5. Update the date for this

image

6. Change this to yes, since it is an online event

image

7. The button not working or redirecting to the cfp page

image

in 7th point @thulieblack do we need that button Its already present in the banner?

@ashmit-coder
Copy link
Collaborator Author

Secondly where should the Register Now button on home page redirect to?

cc: @thulieblack

@ashmit-coder
Copy link
Collaborator Author

Can I get a vertically scaled image of the mic as well for the carousel @thulieblack

@thulieblack
Copy link
Member

  1. Yes @ashmit-coder you can include the button so that a person doesn't have to scroll up again to submit

  2. Im working on a PR that has the details to the Register Now button

  3. Yes please scale the image its not looking that okay now

@ashmit-coder
Copy link
Collaborator Author

ptal @thulieblack

@thulieblack
Copy link
Member

Looks good, I think the rest can be follow-up issues

@AceTheCreator @Mayaleeeee any last changes? we are a bit behind time other issues can be done as follow-up wdyt?

@Mayaleeeee
Copy link
Member

Looks good, I think the rest can be follow-up issues

@AceTheCreator @Mayaleeeee any last changes? we are a bit behind time other issues can be done as follow-up wdyt?

Yes, please.

Looks good 👍 👌

@AceTheCreator AceTheCreator merged commit 0039fb9 into asyncapi:master Aug 30, 2024
12 checks passed
ashmit-coder added a commit to ashmit-coder/conference-website that referenced this pull request Sep 9, 2024
* initial commit for CFP and speakers form

* changes to the form

* removed comments

* added example env

* changes to apply btn

* configured the speakers register API

* changed path for CFP

* url correction

* added Online conference in the Navbar

* Made CFP banner and details json dependent

* update cfp page

* Update dates

* Update eventDetails.js

* test commit

* configured to build

* temp changes to form

* changes to form style

* changed email message

* changed the email message

* changed cfp dates

* changes to cfp css

* changes to online page

* deleted useless components

* Update README.md

* Update README.md

* added speakers guideline component

* changes to guidelines

* changed carousel image

* changes for production

* changes to env names

* testing changes

* test 2

* test 3

* test 4

* test 5

* test 6

* changes to netlify.toml

* test 1

* test 2

* test 3

* test 4

---------

Co-authored-by: asyncapi-bot <[email protected]>
Co-authored-by: V Thulisile Sibanda <[email protected]>
Co-authored-by: Ace <[email protected]>
Co-authored-by: acethecreator <[email protected]>
ashmit-coder added a commit that referenced this pull request Nov 16, 2024
* Added cypress - Initial commit

* added landing page test

* added nav link tests

* merge head

* test

* feat: update agenda times (#354)

* feat: add postman logo in financial support section (#357)


Co-authored-by: V Thulisile Sibanda <[email protected]>%0ACo-authored-by: asyncapi-bot <[email protected]>%0ACo-authored-by: prashantrai-30 <[email protected]>

* add-ticket-link (#358)

* feat: update agenda (#361)

* feat: update ticket cards (#359)


Co-authored-by: acethecreator <[email protected]>

* feat: added the CFP form (#348)

* initial commit for CFP and speakers form

* changes to the form

* removed comments

* added example env

* changes to apply btn

* configured the speakers register API

* changed path for CFP

* url correction

* added Online conference in the Navbar

* Made CFP banner and details json dependent

* update cfp page

* Update dates

* Update eventDetails.js

* test commit

* configured to build

* temp changes to form

* changes to form style

* changed email message

* changed the email message

* changed cfp dates

* changes to cfp css

* changes to online page

* deleted useless components

* Update README.md

* Update README.md

* added speakers guideline component

* changes to guidelines

* changed carousel image

* changes for production

* changes to env names

* testing changes

* test 2

* test 3

* test 4

* test 5

* test 6

* changes to netlify.toml

* test 1

* test 2

* test 3

* test 4

---------

Co-authored-by: asyncapi-bot <[email protected]>
Co-authored-by: V Thulisile Sibanda <[email protected]>
Co-authored-by: Ace <[email protected]>
Co-authored-by: acethecreator <[email protected]>

* chore(deps): bump axios from 1.6.0 to 1.7.4 (#368)

* Revert "feat: update ticket cards (#359)"

This reverts commit 066c265.

* revert netlify

* ticket update

* fix-button (#369)

* fix: added online cfp form (#371)

* added online cfp form

* testing different toml configuration

* ehanced config

* testing new config

* fixed typo

* fixed cfp date

* fixed smtp pass typo (#372)

* fix issue #356 (#374)

* Dropdown bug fixed (#353)

Co-authored-by: Cody's Dad <[email protected]>

* feat: update speakers.json (#383)

* Merge master

* package lock changes

* changes to package lock

* fix bug in home

* added navbar mobile tests

* added base venue tests

* added cfp test

* package-lock changes

* added cypress test

* changes to setup versions

* changes to regex

* test commit

---------

Co-authored-by: V Thulisile Sibanda <[email protected]>
Co-authored-by: prashantrai-30 <[email protected]>
Co-authored-by: V Thulisile Sibanda <[email protected]>%0ACo-authored-by: asyncapi-bot <[email protected]>%0ACo-authored-by: prashantrai-30 <[email protected]>
Co-authored-by: acethecreator <[email protected]>
Co-authored-by: asyncapi-bot <[email protected]>
Co-authored-by: Ace <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Saurbh Kumar <[email protected]>
Co-authored-by: Ujjwal Tyagi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants