-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dynamically adjust dropdown width to prevent text wrapping #504
base: master
Are you sure you want to change the base?
fix: dynamically adjust dropdown width to prevent text wrapping #504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! the workflow seems to be failing due to the year changing from 2024 to 2025.
hey @thulieblack should we change the year on the main page to 2025 or merge the pr's if only this test is failing? |
Yes @ashmit-coder , The error is occurring because the test "Contains correct heading" for the landing page heading is expecting the text: I have created PR #506 implementing the second solution. Root Cause of the Error:In the file https://github.com/asyncapi/conference-website/blob/master/cypress/e2e/Landing.cy.js
Possible Solutions
Current Code
Proposed New Code
Current Code
Proposed New Code
|
Description
This PR addresses the issue where the dropdown menu in the navigation bar had a fixed width, causing text wrapping for longer items and excessive space for shorter items. The dropdown width now adjusts dynamically based on the length of the longest link, ensuring a more consistent and responsive UI.
Screenshot
Fixes #503