test: Use testcontainers for integration tests requiring Postgres #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than requiring the environment to supply a suitable database, we may use TestContainers to provision a fresh database for each test. This allows contributors to run the entire test suite without project-specific setup, although it does require a working Docker environment.
|
Thank you for opening this, however I really don't want to add a dependency on Docker for our tests to complete. It should be up to the developer how they wish to run the database Personally, I run a non-containerized postgres locally for all of my development. Docker has a non-negligeable impact on battery usage for laptops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than requiring the environment to supply a suitable database, we may use TestContainers to provision a fresh database for each test. This allows contributors to run the entire test suite without project-specific setup, although it does require a working Docker environment.
Checks