Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RunsOn #837

Closed
wants to merge 4 commits into from
Closed

Add RunsOn #837

wants to merge 4 commits into from

Conversation

crohr
Copy link

@crohr crohr commented Aug 28, 2024

Thanks for taking the time to suggest an addition to awesome-selfhosted!

To ensure your Pull Request is dealt with swiftly, please check the following (check the boxes [x]):

  • Submit one item per pull request. This eases reviewing and speeds up inclusion.
  • You have searched the repository for any relevant issues or PRs, including closed ones.
  • Any software you are adding is not already listed at any of awesome-sysadmin, staticgen.com, staticsitegenerators.net, dbdb.io.
  • The file you are adding is formatted as described in addition.md.
  • Demo links should only be used for interactive demos, i.e. not video demonstrations.
  • Comments and unused optional fields have been removed.
  • The file you are adding uses kebab-case file naming, for example my-awesome-software.yml.
  • Values for platform are the main server-side requirements for the software. Don't include frameworks or specific dialects.
  • Any software project you are adding to the list is actively maintained.
  • Any software project you are adding was first released more than 4 months ago.
  • Any software project you are adding has working installation instructions.
  • You understand that your Pull Request will be merged ~1 week after approval, to allow for further comments if needed.

@crohr crohr marked this pull request as ready for review August 28, 2024 11:31
@crohr crohr changed the title Add runs-on.com Add RunsOn Aug 28, 2024
@Rabenherz112 Rabenherz112 added addition Adding new software to the list reviewers wanted Awaiting reviews non-free Non-Free (Libre) software labels Aug 28, 2024
kokomo123
kokomo123 reviewed Sep 1, 2024
View reviewed changes
software/runs-on.yml Outdated Show resolved Hide resolved
@crohr @kokomo123
Update runs-on.yml
f01c049 
Co-authored-by: kokomo123 <[email protected]>
kokomo123
kokomo123 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@kokomo123 kokomo123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - No issues here, pending other thoughts from collaborators 👍🏻

@nodiscc
Copy link
Member

nodiscc commented Sep 6, 2024

self-hosted in your AWS account

There is precedent in previous issues/pull requests that software which depends on specific cloud providers does not qualify as self-hosted.

@nodiscc nodiscc closed this Sep 6, 2024
@nodiscc nodiscc added invalid This doesn't seem right and removed reviewers wanted Awaiting reviews labels Sep 6, 2024
@crohr
Copy link
Author

crohr commented Sep 6, 2024

self-hosted in your AWS account

There is precedent in previous issues/pull requests that software which depends on specific cloud providers does not qualify as self-hosted.

Ok I ~understand, would be nice if it could be added to the PR template or instructions to avoid unnecessary work.

@kokomo123 kokomo123 mentioned this pull request Sep 6, 2024
Open
@nodiscc nodiscc mentioned this pull request Sep 6, 2024
Open
@nodiscc
Copy link
Member

nodiscc commented Sep 6, 2024

added to the PR template or instructions to avoid unnecessary work

I will, thank you - I've added this to the general discussion about contribution guidelines improvements #594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kokomo123 kokomo123 kokomo123 approved these changes

Assignees
No one assigned
Labels
addition Adding new software to the list invalid This doesn't seem right non-free Non-Free (Libre) software
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crohr @nodiscc @kokomo123 @Rabenherz112