Skip to content

Commit

Permalink
Update ACK runtime to v0.19.1 (#90)
Browse files Browse the repository at this point in the history
Issue #, if available: aws-controllers-k8s/community#1350

Description of changes:
* Update ACK runtime to v0.19.1
* ignore ACK system tags from the tag assertion in e2e tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • Loading branch information
vijtrip2 authored Jun 17, 2022
1 parent 48abf6c commit 5e5a5dc
Show file tree
Hide file tree
Showing 38 changed files with 718 additions and 59 deletions.
12 changes: 6 additions & 6 deletions apis/v1alpha1/ack-generate-metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2022-06-15T23:33:58Z"
build_hash: 6acf40fe3e3cfd97b799ef7cbf1e89e01c3db8f7
go_version: go1.18.2
version: v0.18.4-15-g6acf40f
api_directory_checksum: 7ded8dc716ff929b62e5d5b43a2c656a55f85985
build_date: "2022-06-17T17:52:08Z"
build_hash: a45f3b900849ec03c5e16ed2778c0b8e2923ffee
go_version: go1.17.5
version: v0.19.1
api_directory_checksum: 4bdcfc19ab3ec6ae11525e6eb3a201e4a25b00fa
api_version: v1alpha1
aws_sdk_go_version: v1.42.0
generator_config_info:
file_checksum: 88ac4e4fff9ca9605e40c329178021face7472a8
file_checksum: c9c7e5d1decf6b529a8b451570ccc4fdfe1e6f79
original_file_name: generator.yaml
last_modification:
reason: API generation
2 changes: 2 additions & 0 deletions apis/v1alpha1/generator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ resources:
fields:
GlobalClusterIdentifier:
is_primary_key: true
tags:
ignore: true
DBParameterGroup:
renames:
operations:
Expand Down
3 changes: 2 additions & 1 deletion cmd/controller/main.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion config/controller/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ spec:
- name: ACK_LOG_LEVEL
value: "info"
- name: ACK_RESOURCE_TAGS
value: "services.k8s.aws/managed=true,services.k8s.aws/created=%UTCNOW%,services.k8s.aws/namespace=%KUBERNETES_NAMESPACE%"
value: "services.k8s.aws/controller-version=%CONTROLLER_SERVICE%-%CONTROLLER_VERSION%,services.k8s.aws/namespace=%K8S_NAMESPACE%"
securityContext:
allowPrivilegeEscalation: false
privileged: false
Expand Down
2 changes: 1 addition & 1 deletion config/controller/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ kind: Kustomization
images:
- name: controller
newName: public.ecr.aws/aws-controllers-k8s/rds-controller
newTag: v0.0.24
newTag: v0.0.25
2 changes: 2 additions & 0 deletions generator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ resources:
fields:
GlobalClusterIdentifier:
is_primary_key: true
tags:
ignore: true
DBParameterGroup:
renames:
operations:
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ go 1.17

require (
github.com/aws-controllers-k8s/kms-controller v0.0.15
github.com/aws-controllers-k8s/runtime v0.18.4
github.com/aws-controllers-k8s/runtime v0.19.1
github.com/aws/aws-sdk-go v1.42.0
github.com/go-logr/logr v1.2.0
github.com/spf13/pflag v1.0.5
Expand Down
3 changes: 2 additions & 1 deletion go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,9 @@ github.com/armon/go-radix v0.0.0-20180808171621-7fddfc383310/go.mod h1:ufUuZ+zHj
github.com/asaskevich/govalidator v0.0.0-20190424111038-f61b66f89f4a/go.mod h1:lB+ZfQJz7igIIfQNfa7Ml4HSf2uFQQRzpGGRXenZAgY=
github.com/aws-controllers-k8s/kms-controller v0.0.15 h1:v9LLAE2Q517CvlP80EgXNq2juGCTLUfpn1OjBGY+n8Y=
github.com/aws-controllers-k8s/kms-controller v0.0.15/go.mod h1:EbxvdZDS2n3JCMmhfjhavSutzt/9J0jXSvGj2bufS68=
github.com/aws-controllers-k8s/runtime v0.18.4 h1:iwLYNwhbuiWZrHPoulGj75oT+alE91wCNkF1FUELiAw=
github.com/aws-controllers-k8s/runtime v0.18.4/go.mod h1:oA8ML1/LL3chPn26P6SzBNu1CUI2nekB+PTqykNs0qU=
github.com/aws-controllers-k8s/runtime v0.19.1 h1:OBV7vbIbLFRpXdAwJfoPGphhjTa7xSc3pS/kuYlKzRU=
github.com/aws-controllers-k8s/runtime v0.19.1/go.mod h1:oA8ML1/LL3chPn26P6SzBNu1CUI2nekB+PTqykNs0qU=
github.com/aws/aws-sdk-go v1.42.0 h1:BMZws0t8NAhHFsfnT3B40IwD13jVDG5KerlRksctVIw=
github.com/aws/aws-sdk-go v1.42.0/go.mod h1:585smgzpB/KqRA+K3y/NL/oYRqQvpNJYvLm+LY1U59Q=
github.com/benbjohnson/clock v1.0.3/go.mod h1:bGMdMPoPVvcYyt1gHDf4J2KE153Yf9BuiUKYMaxlTDM=
Expand Down
4 changes: 2 additions & 2 deletions helm/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v1
name: rds-chart
description: A Helm chart for the ACK service controller for Amazon Relational Database Service (RDS)
version: v0.0.24
appVersion: v0.0.24
version: v0.0.25
appVersion: v0.0.25
home: https://github.com/aws-controllers-k8s/rds-controller
icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
sources:
Expand Down
2 changes: 1 addition & 1 deletion helm/templates/NOTES.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{ .Chart.Name }} has been installed.
This chart deploys "public.ecr.aws/aws-controllers-k8s/rds-controller:v0.0.24".
This chart deploys "public.ecr.aws/aws-controllers-k8s/rds-controller:v0.0.25".

Check its status by running:
kubectl --namespace {{ .Release.Namespace }} get pods -l "app.kubernetes.io/instance={{ .Release.Name }}"
Expand Down
10 changes: 10 additions & 0 deletions helm/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,13 @@ If release name contains chart name it will be used as a full name.
{{- .Release.Namespace -}}
{{- end -}}
{{- end -}}

{{/* The mount path for the shared credentials file */}}
{{- define "aws.credentials.secret_mount_path" -}}
{{- "/var/run/secrets/aws" -}}
{{- end -}}

{{/* The path the shared credentials file is mounted */}}
{{- define "aws.credentials.path" -}}
{{- printf "%s/%s" (include "aws.credentials.secret_mount_path" .) .Values.aws.credentials.secretKey -}}
{{- end -}}
16 changes: 16 additions & 0 deletions helm/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,16 @@ spec:
value: {{ .Values.log.level | quote }}
- name: ACK_RESOURCE_TAGS
value: {{ join "," .Values.resourceTags | quote }}
{{- if .Values.aws.credentials.secretName }}
- name: AWS_SHARED_CREDENTIALS_FILE
value: {{ include "aws.credentials.path" . }}
- name: AWS_PROFILE
value: {{ .Values.aws.credentials.profile }}
volumeMounts:
- name: {{ .Values.aws.credentials.secretName }}
mountPath: {{ include "aws.credentials.secret_mount_path" . }}
readOnly: true
{{- end }}
securityContext:
allowPrivilegeEscalation: false
privileged: false
Expand All @@ -101,3 +111,9 @@ spec:
hostIPC: false
hostNetwork: false
hostPID: false
{{ if .Values.aws.credentials.secretName -}}
volumes:
- name: {{ .Values.aws.credentials.secretName }}
secret:
secretName: {{ .Values.aws.credentials.secretName }}
{{ end -}}
15 changes: 15 additions & 0 deletions helm/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,21 @@
},
"endpoint": {
"type": "string"
},
"credentials": {
"description": "AWS credentials information",
"properties": {
"secretName": {
"type": "string"
},
"secretKey": {
"type": "string"
},
"profile": {
"type": "string"
}
},
"type": "object"
}
},
"type": "object"
Expand Down
14 changes: 10 additions & 4 deletions helm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

image:
repository: public.ecr.aws/aws-controllers-k8s/rds-controller
tag: v0.0.24
tag: v0.0.25
pullPolicy: IfNotPresent
pullSecrets: []

Expand Down Expand Up @@ -50,6 +50,13 @@ aws:
# If specified, use the AWS region for AWS API calls
region: ""
endpoint_url: ""
credentials:
# If specified, Secret with shared credentials file to use.
secretName: ""
# Secret stringData key that contains the credentials
secretKey: "credentials"
# Profile used for AWS credentials
profile: "default"

# log level for the controller
log:
Expand All @@ -64,9 +71,8 @@ installScope: cluster
resourceTags:
# Configures the ACK service controller to always set key/value pairs tags on
# resources that it manages.
- services.k8s.aws/managed=true
- services.k8s.aws/created=%UTCNOW%
- services.k8s.aws/namespace=%KUBERNETES_NAMESPACE%
- services.k8s.aws/controller-version=%CONTROLLER_SERVICE%-%CONTROLLER_VERSION%
- services.k8s.aws/namespace=%K8S_NAMESPACE%

serviceAccount:
# Specifies whether a service account should be created
Expand Down
42 changes: 40 additions & 2 deletions pkg/resource/db_cluster/manager.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions pkg/resource/db_cluster/references.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 9 additions & 3 deletions pkg/resource/db_cluster/sdk.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

61 changes: 61 additions & 0 deletions pkg/resource/db_cluster/tags.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5e5a5dc

Please sign in to comment.