feat: Include custom Adobe Font files in the submitter job #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahuge
force-pushed
the
ah/feature/fonts-in-submitter
branch
2 times, most recently
from
da9e70c to
5c86725
Compare
|
Will need a rebase once #44 gets merged in. |
Ahuge
force-pushed
the
ah/feature/fonts-in-submitter
branch
2 times, most recently
from
3598969 to
6fa85ce
Compare
These font files are required to render the job correctly and should be included in the JobBundle Signed-off-by: Alex Hughes <[email protected]>
Ahuge
force-pushed
the
ah/feature/fonts-in-submitter
branch
3 times, most recently
from
6ab1729 to
482a6e8
Compare
Our adaptor will now install any font files uploaded with the job as a part of its "Launch After Effects" step. It is installing these fonts to the User and not the System so Admin permissions should not be required. Signed-off-by: Alex Hughes <[email protected]>
Ahuge
force-pushed
the
ah/feature/fonts-in-submitter
branch
from
482a6e8 to
00762dc
Compare
The code change I made does adds a check for the User Font directory and create it if it don't exist. ### Testing With the script changes, it creates the Fonts folder under the "C:\Users\skarpree\AppData\Local\Microsoft\Windows\" if the path doesn't exists.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
When a user uses Adobe Fonts, those custom fonts get installed in their appdata directory and are not included in the job.
The resulting render does not have the correct fonts.
What was the solution? (How)
We query the scene and collect all of the custom adobe fonts. These fonts are uploaded as job attachments and the adaptor will install the fonts for the currently running user during the launch of After Effects.
When After Effects is closed, the fonts are uninstalled.
What is the impact of this change?
After Effects renders that use custom Adobe Fonts render correctly
How was this change tested?
I have tested it running a modified version of the standard AfterEffects submitter template with a local session-runner.
These files can be found here: https://gist.github.com/Ahuge/ab8da83c16e5ceadb8683bbde4d9155a
The main change in the template was goofing around with my VirtualEnv as a JobEnvironment
I will deploy this to my own Deadline farm and confirm things there as well.
Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
Was this change documented?
Not yet
Is this a breaking change?
I suppose?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.