You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assumption that the executable afterfx.exe exists on the PATH doesn't always make sense, often it is easier to specify the version of AfterEffects to use by explicit path and using an environment variable is an easy way to do this for customers.
What was the solution? (How)
We have defined a new environment variable AFTERFX_EXECUTABLE which follows the naming from deadline-cloud-for-cinema-4d of <EXE_NAME>_EXECUTABLE
What is the impact of this change?
Breaking change as we changed the name of the existing environment variable.
How was this change tested?
Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
Required: paste the contents of job_bundle_output_tests/test-job-bundle-results.txt here
Was this change documented?
Yes, FAQ.md and DEVELOPMENT.md
Is this a breaking change?
Yes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eherozhao
changed the title
This now matches the other new DCC naming scheme
What was the problem/requirement? (What/Why)
The assumption that the executable afterfx.exe exists on the PATH doesn't always make sense, often it is easier to specify the version of AfterEffects to use by explicit path and using an environment variable is an easy way to do this for customers.
What was the solution? (How)
We have defined a new environment variable
AFTERFX_EXECUTABLEwhich follows the naming fromdeadline-cloud-for-cinema-4dof<EXE_NAME>_EXECUTABLEWhat is the impact of this change?
Breaking change as we changed the name of the existing environment variable.
How was this change tested?
Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
Was this change documented?
Yes, FAQ.md and DEVELOPMENT.md
Is this a breaking change?
Yes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.