feat!: Quicktime Movie Submission Workflows #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now matches the other new DCC naming scheme Signed-off-by: Alex Hughes <[email protected]>
Signed-off-by: Alex Hughes <[email protected]>
This happens via a FrameStart, FrameEnd, ChunkSize and 2 internal parameters that are just calculations based on the previous ones. We've also reorganized some of the code to hopefully isolate it against future changes. Signed-off-by: Alex Hughes <[email protected]>
Signed-off-by: Alex Hughes <[email protected]>
Signed-off-by: Alex Hughes <[email protected]>
Signed-off-by: Alex Hughes <[email protected]>
|
Thanks for the PR! We are having a new dockable submitter with aerender and I think it should automatically solve this issue that old submitter had. Do you want to try it out and see if the new submitter works for this .mov output out of box? |
…to an uncompressed mov with ffmpeg
The client IPC workflow is removed
This will allow us to string replace it with the actual frame rate from the comp that we are submitting
feature: added a checkbox that adds an OpenJD step to convert image sequences with ffmpeg
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Current submissions were only supported for Frame based workflows and if you were rendering out a movie file, it would continuously overwrite it. See #73
What was the solution? (How)
Implement an automatic movie workflow if we detect the output of a comp is a movie extension
What is the impact of this change?
This will automatically submit a single task job for the movie render if it detects it.
How was this change tested?
Ran the workflow through all three submission queue types and tested both with a scene containing a frame comp and and a movie comp as well as just two movie comps.
Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
Was this change documented?
No
Is this a breaking change?
Yes, functionality for movie workflows has been changed
** This is built on top of #77 and should be on hold until that gets in
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.