Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: image chunking #93

Draft
wants to merge 3 commits into
base: feature_dockable_submitter
Choose a base branch
from

Conversation

eherozhao
Copy link
Contributor

@eherozhao eherozhao commented Jan 10, 2025

What was the problem/requirement? (What/Why)

Before we have native OpenJD feature Chunking (see RFC for more details https://github.com/OpenJobDescription/openjd-specifications/pull/54/files), we would like to have this feature in After Effects submitter for customers to have their image sequences chucked to increase the total rendering time.

What was the solution? (How)

  1. The submitter allows customers to pass in a param Frames per task (ChunkSize) and then depending on this number and the range of frames, there will be chunked tasks and assigned to workers.
  2. Rewrote PS script to Python to be more portable.

What is the impact of this change?

  1. Customer can use chunking in AE submitter.

How was this change tested?

Submitted AE job with video output and image output.

The image job will be split to multiple tasks based on chunk size. Example as follows.
image

I tested the following sceanrios:

  1. 0-2999 frames for video output.
  2. 0-2999 frames with 1000 chunk size => 3 chunks or 3 tasks
  3. 0-2999 frames with 1 chunk size => 3000 chunks or 3000 tasks
  4. 100-299 frames with 300 chunk size => 1 chunk or 1 task
  5. 100-299 frames with 299 chunk size => 2 chunks or 2 tasks, the second task only has 1 frame.

Was this change documented?

Is this a breaking change?

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eherozhao eherozhao changed the title Feature new image chunking feat: image chunking Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant