Fix document step by step guide #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,9 @@ | |||
| .DS_Store | |||
| china/.DS_Store | |||
There was a problem hiding this comment.
please remove .DS_Store
There was a problem hiding this comment.
you can ignore .gitignore self
| @@ -106,9 +106,9 @@ eksctl utils associate-iam-oidc-provider --cluster=${CLUSTER_NAME} --approve --r | |||
| * 请注意官方的policy里面包含了WAF等服务，中国区没有所以需要手动删除,修改好的已经放在resource/alb-ingress-controller目录下 | |||
|
|
|||
| ```bash | |||
| cd resource/alb-ingress-controller | |||
| cd china/2020_EKS_Launch_Workshop/resource/alb-ingress-controller | |||
There was a problem hiding this comment.
I prefer all step guide lab context is china/china/2020_EKS_Launch_Workshop,
so, we only use kubectl apply -f resource//xxx.yaml / or /xxxx.yaml.
| @@ -68,9 +68,9 @@ sudo mv ./eksctl /usr/local/bin | |||
| #kubectl | |||
| https://docs.aws.amazon.com/eks/latest/userguide/install-kubectl.html | |||
| #macOS | |||
| curl -o kubectl https://amazon-eks.s3-us-west-2.amazonaws.com/1.15.10/2020-02-22/bin/darwin/amd64/kubectl | |||
There was a problem hiding this comment.
this is fix md format issue ? Sorry, I'm don't get your point :<
There was a problem hiding this comment.
It is typo. I have fixed it.
|
Thank your PR ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #2 Issue #4 Issue #5 Issue #6 #7 #8 Issue #12 *
Description of changes:
Update the document for more and clear step by step guide
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.