Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add length validation to route name #725

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apis/appmesh/v1beta2/virtualrouter_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,8 @@ type GRPCRoute struct {
// Route refers to https://docs.aws.amazon.com/app-mesh/latest/APIReference/API_RouteSpec.html
type Route struct {
// Route's name
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:MaxLength=255
Name string `json:"name"`
// An object that represents the specification of a gRPC route.
// +optional
Expand Down
2 changes: 2 additions & 0 deletions config/crd/bases/appmesh.k8s.aws_virtualrouters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -943,6 +943,8 @@ spec:
type: object
name:
description: Route's name
maxLength: 255
minLength: 1
type: string
priority:
description: The priority for the route.
Expand Down
2 changes: 2 additions & 0 deletions config/helm/appmesh-controller/crds/crds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3813,6 +3813,8 @@ spec:
type: object
name:
description: Route's name
maxLength: 255
minLength: 1
type: string
priority:
description: The priority for the route.
Expand Down