Repository navigation
Conversation
Collapse generated service clients, tests, generator-written core files and synced models in GitHub PR diffs.
Madrigal
marked this pull request as ready for review
November 11, 2026 15:49
Madrigal
requested review from
averyk22 and
pulimsr
and removed request for
pulimsr
November 11, 2026 15:56
averyk22
approved these changes
Nov 11, 2026
Madrigal
enabled auto-merge
November 11, 2026 18:31
github-merge-queue
Bot
removed this pull request from the merge queue due to Branch Protection failures
Nov 11, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: None.
Description of changes:
This adds a
.gitattributesthat marks generated files aslinguist-generated. GitHub collapses those files bydefault in PR diffs and leaves them out of language stats. It's the same approach as kubernetes/kubernetes and
aws/aws-sdk-go-v2#3636. No source changes.
The generated C++ has no "generated" header, and Linguist's header rule only applies to Go anyway, so today none of
it is collapsed. The rules follow the output paths in the generator code:
/generated/**(exceptgenerated/smoke-tests/RunTests.cpp)rmtree+ extract), endpoint/include tests,protocol_tests_gen.py,smoke_tests_gen.pyClientConfigurationDefaults.*,AWSPartitions.*CppDefaultsGenerator,CppPartitionsGeneratortools/CI/install-test/all_services_test.cppinstall_test_gen.pytools/code-generation/smithy/**/smithy-build.jsonbuild.gradle.ktsapi-descriptions/**,endpoints/**, defaults/partitions JSON, protocol-test models and suitesfetch_latest_models.py(verbatim upstream copy), and the Smithy protocol-test modelsThese stay visible on purpose:
RunTests.cpp, the mixedinstall-test/CMakeLists.txt,Region.h,VERSION,VersionConfig.h,CHANGELOG.mdand the generator.java/.vmsources. Release automation touches them, butthey also carry hand-written changes.
Verification. I ran
git check-attr linguist-generatedon all 175,207 tracked files:.vmtemplates, the doxygenlayout, and 2
gradlewfiles that Linguist already handles.Effect on recent PRs (lines hidden by default):
.vmandXmlSerializerchangesFor reviewers: when a PR changes the generator, expand the collapsed regenerated files to see its effect. The
copied-in models are their own block, in case you'd rather keep them visible.
No changelog fragment: this doesn't change SDK behavior (see CONTRIBUTING.md).
Check all that applies:
.gitattributesonly, verified withgit check-attras above.)Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.