Repository navigation
Decode rpcv2Cbor initial-response members and send the event stream Accept header - #3996
Merged
Merged
Conversation
sbiscigl
marked this pull request as ready for review
November 11, 2026 21:19
sbiscigl
force-pushed
the
rpcv2cbor-initial-response-fix
branch
from
November 11, 2026 21:42
709f9a5 to
6595923
Compare
wty-Bryant
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fixes initial response member and accept header on event streaming operation that use CBOR.
note: this was tested using the branch https://github.com/aws/aws-sdk-cpp/tree/rpcv2cbor-eventstream-protocol-tests which has a naive implementation of event stream protocol tests. it is much larger and likely should not be merged with this fix for the sake of velocity, however that is how ti was tested.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.