Repository navigation
Derive service directory name from serviceId instead of model file name - #3999
Open
wty-Bryant wants to merge 2 commits into
Open
wty-Bryant wants to merge 2 commits into
wty-Bryant wants to merge 2 commits into
Conversation
sbiscigl
approved these changes
Nov 13, 2026
| @@ -40,7 +40,6 @@ | |||
| "route-53-domains": "route53domains", | |||
| "route-53": "route53", | |||
| "s3-control": "s3control", | |||
| "sagemaker-runtime": "sagemaker-runtime", | |||
Collaborator
There was a problem hiding this comment.
The three entries removed from smithy/cpp-codegen/smithy2c2j_service_map.json don't affect folder resolution either way. sagemaker-runtime maps to itself, and importexport/sdb hit the no-serviceId fallback before the map is checked. Every other reader of this file falls back to the identity name when an entry is missing.
Removing them just makes this copy drift from smithy/codegen/smithy2c2j_service_map.json, which smoke test generation reads and where these entries do matter. Can we revert the map change and keep the PR scoped to model_utils.py?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fold the generated package folder and CMake project/target/path names off the service id (via the shared service map) instead of the model file name, so the filename no longer influences generated output. Also source CMake project/test descriptions from the service full name and drop the hardcoded "AWS" brand + path-as-display-name.
Folder derivation is byte-identical (verified by re-genereating all services using
python3 tools/scripts/run_code_generation.py --alland a filename-rename sentinel guard that uses some python scripts to give every c2j model name a "sentinelzz" prefix); the only output change is the CMake description strings across 876 regenerated CMakeLists.txt, which should not impact runtime cpp code.