Repository navigation
Conversation
wty-Bryant
reviewed
Nov 13, 2026
| if (getter.equals(resultClassName)) { | ||
| getter = "Get" + getter; | ||
| } | ||
| resultClassName = null; |
Contributor
There was a problem hiding this comment.
wonder if this null reset for resultClassName is really needed since the TopLevelVisitor creates a new emitter for every result access
Collaborator
Author
There was a problem hiding this comment.
got rid of it, the right side of a subexpression gets its own emitter now so only the first field can get renamed
wty-Bryant
approved these changes
Nov 13, 2026
…r's getter name matches its result class name.
sbiscigl
force-pushed
the
waiter-result-getter-collision
branch
from
November 13, 2026 20:34
376701f to
73e20e9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
When an output member's getter would have the same name as the result class, the model generator adds another
Get, but the waiter generator didn't. For an operationGetFoowith an output memberfooResult:Regenerating all clients produces no changes.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.