Conversation
Serialize unixTimestamp and iso8601 request timestamps with the sub-second precision the caller provided instead of truncating to whole seconds. Whole-second values are unchanged; rfc822 remains whole seconds per spec. Add TimestampShape::formatAsString for string-bound locations (query, XML, REST headers/querystring/URI) so float epoch values are not truncated by PHP's `precision` ini setting when cast to string.
smilkuri
requested review from
lukasdchang,
rohangavankar and
stobrien89
as code owners
September 17, 2026 14:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After CI succeeds merge #3353