Add support for annotations in backtrace analysis #126
+81
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahinfalcon
changed the title
|
Thank you for the contribution! I think we just need a few tests in the backtrace analysis with the annotations. For example we have similar ones for the taint analysis with data in analysis/taint/testdata/annotations. |
|
I'll write some tests, thanks for the feedback 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #104
Description of changes: Adds support for annotations in backtrace analysis by adding the calls to state.ResolveSsaNode in analysis/dataflow/code_identifiers.go and the new backtrace annotations in analysis/annotations/annotations.go as outlined in #104
All local tests run OK 😄
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.