-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with Snapshot testing (not updated) #624
Comments
After the 1.10.1 release, there is still the issue where the automated_tests workflow runs against the main branch and not the feature branch. This is evident from this action run https://github.com/awslabs/landing-zone-accelerator-on-aws/actions/runs/11946584954. The action completes a check per this log: https://github.com/awslabs/landing-zone-accelerator-on-aws/actions/runs/11946584954/job/33301174026#step:2:67 This was acknowledged #611 (comment), please resolve this so we can continue to submit pull requests and not get the ❌ on the builds (as they aren't related to the code changes). Do let me know if my understanding is wrong |
Hey @richardkeit , thanks for bringing attention to this. I was out of office for the last few weeks and was unable to get that fix in before we released v1.10.1. I'm working on this now and will keep this issue updated regarding the release in which I expect this fix to be available. |
Thank you @erwaxler , as released - happy to close Hope you have some time off this end of year period 🎉 |
Thanks @richardkeit , same to you! |
Describe the bug
Snapshot tests are failing due to release of 1.10.
To Reproduce
Run
yarn test
from the source directoryExpected behavior
Snapshot tests pass
Please complete the following information about the solution:
Screenshots
Nil
Additional context
Following https://awslabs.github.io/landing-zone-accelerator-on-aws/latest/developer-guide/features/#snapshot-testing I created this PR #611 . Unfort the tests still fail.
The text was updated successfully, but these errors were encountered: