Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(constructs): service linked role missing permissions #631

Closed
wants to merge 4 commits into from

Conversation

richardkeit
Copy link
Contributor

Issue #, if available:

#629

Description of changes:

Adds permission that was required.

Note: Still issues with snapshots raised in #624 & attempted to be fixed #611

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hickeydh-aws
Copy link
Contributor

hickeydh-aws commented Nov 13, 2024

Hello @richardkeit,

Thank you for taking the time to create this MR. Our team is reviewing this change and we will get back to you if we have any questions!

@richardkeit
Copy link
Contributor Author

Hi @hickeydh-aws,

I raised AWS Support case (173084606300187), attaching Cloudtrail logs for evidence of the missing permission.
Raised another case (173101637500383) in a different Organization as it occurred there also.

Also hoping for #611 that I raised to be merged in (first), given there is duplicate of the update snapshots due to issue #624

@hickeydh-aws
Copy link
Contributor

Thank you for the extra context. We will evaluate the above PRs as well.

@richardkeit richardkeit force-pushed the fix/service-linked-role branch from 74742a9 to a48c639 Compare December 18, 2024 22:59
@richardkeit
Copy link
Contributor Author

Hi @hickeydh-aws , @erwaxler ,

Can I ask you review this once more?

@erwaxler
Copy link
Contributor

Hey @richardkeit , thanks for following up on this. I'm reviewing this code now and expect to incorporate it into our next public release. I will follow-up if I have any questions during testing, otherwise I will let you know once it has been merged. Thank you this contribution!

@erwaxler
Copy link
Contributor

erwaxler commented Jan 6, 2025

Hi @richardkeit , thanks again for your contribution! This has been integrated into the code base and will be included in the next minor release. I'll go ahead and close this, thank you for your support of the Landing Zone Accelerator!

@erwaxler erwaxler closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants