Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch mocking library from golang/mock to go.uber.org/mock #797

Conversation

elprogramadorgt
Copy link
Contributor

@elprogramadorgt elprogramadorgt commented Oct 29, 2024

Switch mocking library from golang/mock to go.uber.org/mock

Summary by CodeRabbit

  • New Features

    • Updated mocking framework from github.com/golang/mock to go.uber.org/mock across various test files and mock implementations.
  • Bug Fixes

    • Ensured compatibility and functionality of tests with the new mocking library while maintaining the original test logic and assertions.
  • Chores

    • Updated dependency versions in go.mod for improved compatibility and functionality.

Copy link
Contributor

coderabbitai bot commented Oct 29, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates the mocking library used throughout the codebase from github.com/golang/mock to go.uber.org/mock. The changes involve modifying import statements across multiple test files and updating the Makefile to install the new mocking tool. Additionally, the go.mod file is updated to reflect the new dependency and version changes for several packages. The overall structure and logic of the tests remain unchanged, ensuring that functionality is preserved while transitioning to a maintained library.

Changes

File Path Change Summary
Makefile Updated mock target to install go.uber.org/[email protected] instead of github.com/golang/mock/[email protected].
go.mod Added new dependency go.uber.org/mock v0.5.0; updated versions for golang.org/x/mod and golang.org/x/tools; modified replacements for several packages.
x/logic/fs/composite/fs_test.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/logic/fs/filtered/fs_test.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/logic/fs/wasm/fs_test.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/logic/keeper/features_test.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/logic/keeper/grpc_query_ask_test.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/logic/keeper/grpc_query_params_test.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/logic/keeper/msg_server_test.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/logic/meter/weighted_test.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/logic/predicate/bank_test.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/logic/predicate/builtin_test.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/logic/predicate/util_test.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/logic/testutil/expected_keepers_mocks.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/logic/testutil/fs_mocks.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/logic/testutil/gas_mocks.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/logic/testutil/interface_registry_mocks.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/logic/testutil/keeper_mocks.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/logic/testutil/read_file_fs_mocks.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/mint/keeper/genesis_test.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/mint/keeper/grpc_query_test.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/mint/keeper/keeper_test.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/mint/testutil/expected_keepers_mocks.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/vesting/msg_server_test.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.
x/vesting/testutil/expected_keepers_mocks.go Updated import from github.com/golang/mock/gomock to go.uber.org/mock/gomock.

Possibly related issues

Possibly related PRs

  • Chore/upgrade golangci-lint to 1.61 #776: This PR involves changes to the Makefile related to the mock generation tool, which is directly connected to the changes in this PR.
  • Chore/go 1.23 #779: This PR updates the Makefile and other configuration files, relating to the overall project structure and dependency management, including the mocking framework updates in this PR.

Suggested reviewers

  • bdeneux
  • ccamel
  • amimart

Poem

🐰 In fields of code where bunnies hop,
We've switched our mocks, we won't stop!
From golang's past to Uber's grace,
Our tests now run at a faster pace!
With every change, our spirits soar,
Hopping high, we code and explore! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@elprogramadorgt elprogramadorgt deleted the refactor/mock-library branch October 31, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant