build(project): update -tags format to use comma-separated values #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coderabbitai review |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #847 +/- ##
=======================================
Coverage 45.03% 45.03%
=======================================
Files 113 113
Lines 6395 6395
=======================================
Hits 2880 2880
Misses 3380 3380
Partials 135 135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
Makefileto use comma-separated values for -tags during Go compilation (e.g., -tags "foo,bar" instead of -tags "foo bar"). This change also includes minor refinements to variable naming.This also addresses the issue during heighliner Docker builds reported in strangelove-ventures/heighliner#299, which was causing the production of an incorrect binary.