Use constructor parameters as source of definitions

Constructor promoted properties provide better flexibility. However,
it's not possible to get their default value as it is part of the
constructor parameter (which assigns the property).

I decided that all inputs need to define a constructor with list of
parameters. Those don't need to be promoted properties, but all
parameters with #[Argument], or #[Option] will be used to create the
definitions.

src/Attributes/Argument.php

@@ -4,7 +4,7 @@
 
 use Attribute;
 
-#[Attribute(Attribute::TARGET_PROPERTY)]
+#[Attribute(Attribute::TARGET_PARAMETER)]
 final class Argument
 {
     public function __construct()

src/Attributes/Description.php

@@ -4,7 +4,7 @@
 
 use Attribute;
 
-#[Attribute(Attribute::TARGET_PROPERTY)]
+#[Attribute(Attribute::TARGET_PARAMETER)]
 final class Description
 {
     public function __construct(

src/Attributes/Name.php

@@ -4,7 +4,7 @@
 
 use Attribute;
 
-#[Attribute(Attribute::TARGET_PROPERTY)]
+#[Attribute(Attribute::TARGET_PARAMETER)]
 final class Name
 {
     public function __construct(public readonly string $name)

src/Attributes/Option.php

@@ -4,7 +4,7 @@
 
 use Attribute;
 
-#[Attribute(Attribute::TARGET_PROPERTY)]
+#[Attribute(Attribute::TARGET_PARAMETER)]
 final class Option
 {
     public function __construct()

src/Attributes/Shortcut.php

@@ -4,7 +4,7 @@
 
 use Attribute;
 
-#[Attribute(Attribute::TARGET_PROPERTY)]
+#[Attribute(Attribute::TARGET_PARAMETER)]
 final class Shortcut
 {
     public function __construct(public readonly string $shortcut)

src/Factory.php

@@ -5,7 +5,7 @@
 use Baethon\Symfony\Console\Input\Attributes\Argument;
 use Baethon\Symfony\Console\Input\Attributes\Option;
 use ReflectionClass;
-use ReflectionProperty;
+use ReflectionParameter;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputOption;
 
@@ -80,13 +80,16 @@ function (ParameterDefinition $parameter) {
      */
     private function collectByType(ReflectionClass $reflection, string $attribute): array
     {
+        $constructor = $reflection->getConstructor()
+            ?? throw new \InvalidArgumentException('Unable to finc constructor of '.$reflection->getName());
+
         $properties = array_filter(
-            $reflection->getProperties(ReflectionProperty::IS_PUBLIC),
-            fn (ReflectionProperty $item) => $item->getAttributes($attribute) !== [],
+            $constructor->getParameters(),
+            fn (ReflectionParameter $item) => $item->getAttributes($attribute) !== [],
         );
 
         return array_map(
-            ParameterDefinition::fromReflectionProperty(...),
+            ParameterDefinition::fromReflectionParameter(...),
             $properties,
         );
     }

src/ParameterDefinition.php

@@ -5,7 +5,7 @@
 use Baethon\Symfony\Console\Input\Attributes\Description;
 use Baethon\Symfony\Console\Input\Attributes\Name;
 use Baethon\Symfony\Console\Input\Attributes\Shortcut;
-use ReflectionProperty;
+use ReflectionParameter;
 use ReflectionType;
 
 final class ParameterDefinition
@@ -22,22 +22,24 @@ public function __construct(
         //
     }
 
-    public static function fromReflectionProperty(ReflectionProperty $property): ParameterDefinition
+    public static function fromReflectionParameter(ReflectionParameter $parameter): ParameterDefinition
     {
-        $type = $property->getType();
-        $defaultValue = $property->getDefaultValue();
+        $type = $parameter->getType();
+        $defaultValue = $parameter->isOptional()
+            ? $parameter->getDefaultValue()
+            : null;
 
         return new self(
-            name: self::findAttribute($property, Name::class)
-                ?->name ?? $property->getName(),
+            name: self::findAttribute($parameter, Name::class)
+                ?->name ?? $parameter->getName(),
             required: match (true) {
                 ! is_null($defaultValue) => false,
                 $type?->allowsNull() => false,
                 default => true,
             },
-            description: self::findAttribute($property, Description::class)
+            description: self::findAttribute($parameter, Description::class)
                 ?->description,
-            shortcut: self::findAttribute($property, Shortcut::class)
+            shortcut: self::findAttribute($parameter, Shortcut::class)
                 ?->shortcut,
             list: ($type instanceof ReflectionType && $type->getName() === 'array'),
             option: ($type instanceof ReflectionType && $type->getName() === 'bool'),
@@ -51,7 +53,7 @@ public static function fromReflectionProperty(ReflectionProperty $property): Par
      * @param  class-string<T>  $attribute
      * @return ?T
      */
-    private static function findAttribute(ReflectionProperty $property, string $attribute)
+    private static function findAttribute(ReflectionParameter $property, string $attribute)
     {
         $attributes = $property->getAttributes($attribute);