Gyro 2-CLP and E-CLP dynamic and immutable info #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndymionJkb
reviewed
Jan 10, 2025
Comment on lines
+14
to
+15
| * @param sqrtAlpha Square root of alpha (the lowest price in the price interval of the 2CLP price curve) | ||
| * @param sqrtBeta Square root of beta (the highest price in the price interval of the 2CLP price curve) |
There was a problem hiding this comment.
Suggested change
| * @param sqrtAlpha Square root of alpha (the lowest price in the price interval of the 2CLP price curve) | |
| * @param sqrtBeta Square root of beta (the highest price in the price interval of the 2CLP price curve) | |
| * @param sqrtAlpha Square root of alpha (the lowest price in the price interval of the 2-CLP price curve) | |
| * @param sqrtBeta Square root of beta (the highest price in the price interval of the 2-CLP price curve) |
Just for consistency
| * @param isPoolPaused If true, the pool is paused, and all non-recovery-mode state-changing operations will revert | ||
| * @param isPoolInRecoveryMode If true, Recovery Mode withdrawals are enabled, and live balances may be inaccurate | ||
| */ | ||
| struct GyroECLPPoolDynamicData { |
There was a problem hiding this comment.
This is the same as the 2-CLP; technically this structure and corresponding function could be shared (i.e., both pool interfaces inherit an additional IGyroPoolDynamicData interface). Not sure if it's worth it.
| @@ -115,8 +126,7 @@ contract Gyro2CLPPool is IGyro2CLPPool, BalancerPoolToken { | |||
| (uint256 virtualParamIn, uint256 virtualParamOut) = _getVirtualOffsets( | |||
| balanceTokenInScaled18, | |||
| balanceTokenOutScaled18, | |||
| tokenInIsToken0, | |||
| request.kind | |||
| tokenInIsToken0 | |||
There was a problem hiding this comment.
What is this argument change in _getVirtualOffsets? Is something not updated, or did another change slip in?
EndymionJkb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gyro pools (2-CLP and E-CLP) should export dynamic and immutable data in the same way that Stable and Weighted pools do, and also inherit PoolInfo contract so that basic functions are available to compute the pool math off-chain.
Type of change
Checklist:
main, or there's a description of how to mergeIssue Resolution
Closes #1214