feat: add an ERC4626 rate provider #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sogipec
commented
Sep 29, 2023
•
sogipec
commented
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1205709778123416
|
Hi @sogipec, thanks for this PR and for the recent changes! We'll get this reviewed and merged by a couple of our engineers. |
0xSpraggins
suggested changes
Oct 18, 2023
There was a problem hiding this comment.
Hi @sogipec thanks for opening this PR and contributing to Balancer. The RateProvider looks good, I just added some minor comments and suggestions regarding some styling changes. I also added an ERC4626RateProviderFactory to support deployments of this rate provider. Let me know if you have any questions!
0xSpraggins
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.