Fix PopupWindow dropdown menus do not display #4201

[gw0]

Fixes #4201 that makes Bambu Studio unusable under some window managers, but reintroduces inconvenience of PopupWindow remaining in front after alt+tab.

[bambu123]

if (!event.GetActive() && IsShown()) DismissAndNotify(); Deleting this code may cause the popup to remain on the desktop, even if the main window has been switched to the background.

…

From: ***@***.***> Date: Thu, Jan 9, 2025, 19:35 Subject: Re: [bambulab/BambuStudio] Fix PopupWindow dropdown menus do not display #4201 (PR #5704) To: ***@***.***> Cc: ***@***.***>, "Review ***@***.***> @lanewei120<https://github.com/lanewei120> requested your review on: #5704<#5704> Fix PopupWindow dropdown menus do not display #4201<#4201> . — Reply to this email directly, view it on GitHub<#5704 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A22TCGEHYIMUNX4GLPSMUDD2JZNJNAVCNFSM6AAAAABUVLKOZ6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVHA3DMNRWGU2TKOA>. You are receiving this because your review was requested.[image: https://github.com/notifications/beacon/A22TCGEQIH6KT6LQPZ5XKLD2JZNJNA5CNFSM6AAAAABUVLKOZ6WGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAAHMN2DJLA.gif]Message ID: ***@***.***>

[gw0]

Deleting this code may cause the popup to remain on the desktop, even if the main window has been switched to the background.

Yes, this does have this consequence. But it is better to have an annoyance when pressing alt+tab than have a unusable app. Removing this line resolves the regression #4201 that makes Bambu Studio unusable.

I am not a GTK expert, but maybe the proper solution for the alt+tab issue would be to use one of the GTK window type hints instead of dismissing popup windows on events (what the problematic line does): https://docs.gtk.org/gdk3/enum.WindowTypeHint.html

[bambu123]

Thank you! OK, Please help merge @lane.wei.

…

From: ***@***.***> Date: Fri, Jan 10, 2025, 16:20 Subject: Re: [bambulab/BambuStudio] Fix PopupWindow dropdown menus do not display #4201 (PR #5704) To: ***@***.***> Cc: ***@***.***>, "Review ***@***.***> > Deleting this code may cause the popup to remain on the desktop, even if the main window has been switched to the background. Yes, this does have this consequence. But it is better to have an annoyance when pressing alt+tab than have a unusable app. Removing this line resolves the regression #4201<#4201> that makes Bambu Studio unusable. I am not a GTK expert, but maybe the proper solution for the alt+tab issue would be to use one of the GTK window type hints instead of dismissing popup windows on events (what the problematic line does): https://docs.gtk.org/gdk3/enum.WindowTypeHint.html — Reply to this email directly, view it on GitHub<#5704 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A22TCGBYAIFD2MS7IA7L4NL2J57FVAVCNFSM6AAAAABUVLKOZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBSGAZTENRSGA>. You are receiving this because your review was requested.[image: https://github.com/notifications/beacon/A22TCGBPHTEZUDURHKY6YZT2J57FVA5CNFSM6AAAAABUVLKOZ6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUZ42YOY.gif]Message ID: ***@***.***>

[lanewei120]

thanks for doing this

[back2ll]

Thank you as well for doing this!