Merge pull request #3298 from bandprotocol/disable-sending-to-dist

Disable sending to account module

CHANGELOG_UNRELEASED.md

@@ -10,6 +10,8 @@
 
 ### Chain (Consensus)
 
+- (bugs) [\#3298](https://github.com/bandprotocol/bandchain/pull/3298) Disable sending token to distribution module
+
 ### Chain (Non-consensus)
 
 ### Yoda

chain/app/app.go

@@ -77,10 +77,6 @@ var (
 		staking.NotBondedPoolName: {supply.Burner, supply.Staking},
 		gov.ModuleName:            {supply.Burner},
 	}
-	// module accounts that are allowed to receive tokens.
-	allowedReceivingModAcc = map[string]bool{
-		distr.ModuleName: true,
-	}
 )
 
 // BandApp is the application of BandChain, extended base ABCI application.
@@ -176,7 +172,7 @@ func NewBandApp(
 	oracleSubspace := app.ParamsKeeper.Subspace(oracle.DefaultParamspace)
 	// Add module keepers.
 	app.AccountKeeper = auth.NewAccountKeeper(cdc, keys[auth.StoreKey], authSubspace, auth.ProtoBaseAccount)
-	app.BankKeeper = bank.NewBaseKeeper(app.AccountKeeper, bankSubspace, app.BlacklistedAccAddrs())
+	app.BankKeeper = bank.NewBaseKeeper(app.AccountKeeper, bankSubspace, app.ModuleAccountAddrs())
 	app.SupplyKeeper = supply.NewKeeper(cdc, keys[supply.StoreKey], app.AccountKeeper, app.BankKeeper, maccPerms)
 	// wrappedSupplyKeeper overrides burn token behavior to instead transfer to community pool.
 	wrappedSupplyKeeper := bandsupply.WrapSupplyKeeperBurnToCommunityPool(app.SupplyKeeper)
@@ -343,15 +339,6 @@ func (app *BandApp) ModuleAccountAddrs() map[string]bool {
 	return modAccAddrs
 }
 
-// BlacklistedAccAddrs returns all the app's module account addresses black listed for receiving tokens.
-func (app *BandApp) BlacklistedAccAddrs() map[string]bool {
-	blacklistedAddrs := make(map[string]bool)
-	for acc := range maccPerms {
-		blacklistedAddrs[supply.NewModuleAddress(acc).String()] = !allowedReceivingModAcc[acc]
-	}
-	return blacklistedAddrs
-}
-
 // Codec returns the application's sealed codec.
 func (app *BandApp) Codec() *codec.Codec {
 	return app.cdc