-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/refactor shared util layout #49
base: main
Are you sure you want to change the base?
Conversation
…shared-util-layout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for now. Just wanted to note here that we will have to see how well the Pagination can be adapted to multiple different contexts. If any issues arise in the future there might be a debate to move it to Shared, as it grows more complex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, we have to see how its going to work out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (alongside LandingPage and NavigationPage) feels kinda weird. Putting them in a folder does make sense, but the naming "Frontend" is a little bland. Perhaps something like "PageProvider" would make it more clear what they do? 🤔 so they would be called -> PageProviderDetail, PageProviderLanding and PageProviderNavigation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand what you mean, but sadly the logic on how the content is rendered requires them to start with Frontend
since the component name is generated from the SW route like frontend.detail.page
.
As agreed in one of our JFs, here is a suggestion to reduce the content of the Layout/Shared/Util folders.
My thoughts about this were:
vue/multi-word-component-names
so I wanted to open the conversation to change this