Repository navigation
feat(mcp)!: split bm_schema into one tool per operation - #2069
Open
phernandez wants to merge 2 commits into
Open
phernandez wants to merge 2 commits into
phernandez wants to merge 2 commits into
Conversation
…and bm_schema_diff One tool per operation (#2030). infer and diff require note_type in the schema; validate keeps its note_type/identifier refusal. bm tool mirrors them as schema-validate, schema-infer and schema-diff; bm schema keeps its shape. Man pages, OpenClaw, skills and guides follow the new names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CMYVL4TcbWdXhdvAzxfqjo Signed-off-by: phernandez <paul@basicmachines.co>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The bulk rename left a mangled tool list in skills/README.md and the root README, and prose calls that passed only `project` to bm_schema_infer and bm_schema_diff, which now require note_type. Pi references regenerated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CMYVL4TcbWdXhdvAzxfqjo Signed-off-by: phernandez <paul@basicmachines.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Second core piece of #2030 (one MCP tool per operation). Stacked on #2068.
What
bm_schemabecomes three read-only tools:bm_schema(command="validate", ...)bm_schema_validateproject(note_typeoridentifieroptional)bm_schema(command="infer", note_type=...)bm_schema_infernote_type,projectbm_schema(command="diff", note_type=...)bm_schema_diffnote_type,projectinfer/diffno longer takeidentifier, and their "needsnote_type" refusals are gone; the schema requires it.bm_schema_validatestill refusesnote_typeandidentifiertogether.bm_schema_infer(note_type=...)).bm tool schema-validate|schema-infer|schema-diff;bm schema validate|infer|diff(the human CLI) keeps its shape and calls the matching tool.bm-schema(3)replaced bybm-schema-validate(3),bm-schema-infer(3),bm-schema-diff(3);tools-migration(7)1.1 table extended.REQUIRED_TOOLSupdated.docs/ai-assistant-guide-extended.md: dropped a stale line sayingrecentwithoutprojectfalls back to the default project.Cloud follow-up
Cloud re-exports core tools; when it pins this stack it picks up the new names. Cloud's own docs, skills and agent prompts that say
bm_schemaneed the same rename.Verification
just fast-checkclean,just man-regenreports no driftjust fast-teston tests/mcp, tests/cli, man page and consumer tests, test-int/mcp, test-int/cli, test-int/bughunt_fixesbun test, typecheck, lint;package-check-skills,package-check-claude-code; benchmarksjust test🤖 Generated with Claude Code
https://claude.ai/code/session_01CMYVL4TcbWdXhdvAzxfqjo