fix(datadirect-puppeteer): Authenticated.fork() to new page

battis · Jan 3, 2025 · 169fd96 · 169fd96
1 parent b41bc90
commit 169fd96
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/packages/datadirect-puppeteer/src/PuppeteerSession/Authenticated.ts b/packages/datadirect-puppeteer/src/PuppeteerSession/Authenticated.ts
@@ -113,16 +113,9 @@ export class Authenticated extends Base {
     return await new Authenticated(this.page).ready();
   }
 
-  public async fork(
-    path: URL | string,
-    timeout = Authenticated.DefaultTimeout
-  ) {
+  public async fork(path: URL | string) {
     await this.ready();
-    const url = await this.url();
-    const fork = await this.clone();
-    const ready = await fork.authenticating.acquire();
-    await fork.goto(new URL(path, url));
-    await fork.appLoaded(timeout, ready);
-    return fork;
+    const base = await super.fork(path);
+    return await new Authenticated(base.page).ready();
   }
 }
diff --git a/packages/datadirect-puppeteer/src/PuppeteerSession/Base.ts b/packages/datadirect-puppeteer/src/PuppeteerSession/Base.ts
@@ -84,7 +84,7 @@ export class Base {
 
   public async clone() {
     await this.ready();
-    return new Base(this.page);
+    return await new Base(this.page).ready();
   }
 
   public async fork(path: URL | string) {