Skip to content

Commit

Permalink
chore(msar): Issue tracking
Browse files Browse the repository at this point in the history
  • Loading branch information
battis committed Jan 3, 2025
1 parent 9cf0079 commit 4ea54aa
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
6 changes: 6 additions & 0 deletions packages/msar/src/bin/commands/download.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ import * as Snapshot from '../../workflows/Snapshot.js';

const snapshotPath = path.resolve(process.cwd(), snapshotPathArg!);

/*
* TODO abstract as much of bin/download into workflow/Download as possible
* The basic design is that the bin scripts are just UI wrappers around
* real objects, not _part_ of the objects
*/
if (!outputPath) {
outputPath = path.join(
path.dirname(snapshotPath!),
Expand Down Expand Up @@ -113,6 +118,7 @@ import * as Snapshot from '../../workflows/Snapshot.js';
'index.json'
);
await common.output.writeJSON(indexPath, index, { pretty });
// TODO output metadata.json of CLI arguments for downloads too

if (quit) {
await spider.quit();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ export class Downloader
outputOptions: { outputPath },
...options
}: Options) {
// FIXME AuthenticatedFetch is instantiating headless
super(`https://${host}`, options);
if (!outputPath) {
throw new common.output.OutputError(
Expand Down

0 comments on commit 4ea54aa

Please sign in to comment.