Skip to content

add input validation for team eligibility changes - #952

Merged
nicolexxuu merged 8 commits into
mainfrom
nicole/eligibility-validation
Dec 7, 2025
Merged

nicolexxuu merged 8 commits into
mainfrom
nicole/eligibility-validation

Conversation

@nicolexxuu

@nicolexxuu nicolexxuu commented Nov 28, 2025 •

Copy link
Copy Markdown
Contributor
  • Add new field is_private to EligibilityCriterion model + make db migrations
  • Raise an exception if a competitor sends patch request to /api/team/episode/t/me/ with criterion that is private or not assigned to episode episode
  • Test erroring logic

Closes #939!

@lowtorola
lowtorola force-pushed the nicole/eligibility-validation branch from 7257221 to 25acbb3 Compare November 30, 2025 21:23
@lowtorola
lowtorola self-requested a review December 3, 2025 00:57
@lowtorola
lowtorola marked this pull request as ready for review December 3, 2025 00:57

@lowtorola lowtorola left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! great work!

@nicolexxuu
nicolexxuu merged commit ceb05c5 into main Dec 7, 2025
3 checks passed
@nicolexxuu
nicolexxuu deleted the nicole/eligibility-validation branch December 7, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No input validation in team eligibility allows adding internal flags like finalist

2 participants