Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A persistent venv can retain a dangling package-directory symlink after the Python runtime changes. When initialization then creates a runtime file link beneath that path,
os.makedirs(..., exist_ok=True)raisesFileExistsErrorinstead of recovering.Remove the parent symlink only when it is confirmed dangling, then create the directory and the current runtime file link. Fixes #4269.
Checks
FileExistsErrorat the parent-directory creation in a credential-isolated sandbox.cached_venv_replaces_dangling_package_symlink_testpassed in the same isolated sandbox (1 test); it checks that the stale package link becomes a directory and the child link resolves to the current runfiles file.git diff --checkpassed.The focused run was on macOS. Windows execution, Bazel, and buildifier were not run.
AI assistance: OpenAI Codex assisted with the patch and regression test; Sean is the submitting author.