feat: add iceoryx #1274
Merged
feat: add iceoryx #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wep21
commented
Jan 6, 2024
wep21
commented
- add iceoryx
fmeum
requested changes
Jan 6, 2024
wep21
force-pushed
the
add-iceoryx
branch
2 times, most recently
from
3c96b34 to
bbb15e9
Compare
|
@fmeum I'm sorry, I removed the lockfile. |
fmeum
added
presubmit-auto-run
fmeum
previously approved these changes
Jan 6, 2024
|
Looks like CI is failing due to missing build files, but the BCR setup looks good. |
wep21
force-pushed
the
add-iceoryx
branch
2 times, most recently
from
3266489 to
cd18c45
Compare
wep21
force-pushed
the
add-iceoryx
branch
3 times, most recently
from
2de3308 to
a6ff15a
Compare
|
@fmeum Do you know how to handle patch adding empty file? It causes a patch error as below. |
|
@wep21 How did you generate the patch? The Bazel implementation of patch can be a bit strict at times. I would recommend using |
bazel-io
dismissed
fmeum’s stale review
Require module maintainers' approval for newly pushed changes.
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (iceoryx) have been updated in this PR. Please review the changes. |
wep21
force-pushed
the
add-iceoryx
branch
4 times, most recently
from
b4884ee to
1acbf7d
Compare
Signed-off-by: wep21 <[email protected]>
wep21
force-pushed
the
add-iceoryx
branch
8 times, most recently
from
df67647 to
411bf92
Compare
Signed-off-by: wep21 <[email protected]>
|
@fmeum @meteorcloudy ready to review |
fmeum
reviewed
Dec 23, 2024
fmeum
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.