fix(frontend): name homepage controls and landmarks - #2867
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The home link still contains a nested interactive button, creating invalid markup and duplicate focus targets.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Improves homepage accessibility semantics and accessible naming.
Changes:
- Adds heading and main landmarks.
- Names home and table action controls.
- Adds corresponding unit tests.
| File | Description |
|---|---|
frontend/src/components/Layout.tsx |
Adds landmarks and home-control labels. |
frontend/src/components/Dashboard.tsx |
Names the actions column. |
frontend/src/components/__tests__/Layout.test.tsx |
Tests layout accessibility semantics. |
frontend/src/components/__tests__/Dashboard.test.tsx |
Tests the actions header name. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
7 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The homepage fails the accessibility checks for a named home control, an actions column header, one main landmark, and a level-one heading.
Closes #2688
Description
The home icon is a link and a button with no accessible name, the actions column header is empty, the page title is a span, and the page body is not a
mainlandmark. The header title is now anh1, the page body is a singlemain, the home control is named, and the actions column header is named for assistive tech.Type of change
How Has This Been Tested?
vitest runforLayout,Dashboard, andNotFound, plusnpm run lintandnpm run format:check, in a Node container.Checklist